Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Gyan
On 24-09-2019 11:39 PM, Gyan wrote: On 24-09-2019 11:38 PM, Marton Balint wrote: On Tue, 24 Sep 2019, Gyan wrote: On 24-09-2019 10:01 PM, Andreas Rheinhardt wrote: There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever retu

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Gyan
On 24-09-2019 11:38 PM, Marton Balint wrote: On Tue, 24 Sep 2019, Gyan wrote: On 24-09-2019 10:01 PM, Andreas Rheinhardt wrote: There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever return a packet with an invalid stream_inde

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Marton Balint
On Tue, 24 Sep 2019, Gyan wrote: On 24-09-2019 10:01 PM, Andreas Rheinhardt wrote: There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever return a packet with an invalid stream_index it is more appropriate for this to be an asser

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Gyan
On 24-09-2019 10:01 PM, Andreas Rheinhardt wrote: There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever return a packet with an invalid stream_index it is more appropriate for this to be an assert. FATE passes with this change. Si

[FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Andreas Rheinhardt
There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever return a packet with an invalid stream_index it is more appropriate for this to be an assert. FATE passes with this change. Signed-off-by: Andreas Rheinhardt --- libavformat/util