Re: [FFmpeg-devel] [PATCH 1/2] swresample/soxr: fix invalid use of linear_interp

2016-11-25 Thread Muhammad Faiz
On 11/25/16, Michael Niedermayer wrote: > On Fri, Nov 25, 2016 at 04:55:34PM +0700, Muhammad Faiz wrote: >> give very bad quality for soxr resampler. >> linear_interp is intended for using linear interpolation >> between filter bank so quality will be better. >> >> i guess this is misunderstood a

Re: [FFmpeg-devel] [PATCH 1/2] swresample/soxr: fix invalid use of linear_interp

2016-11-25 Thread Michael Niedermayer
On Fri, Nov 25, 2016 at 04:55:34PM +0700, Muhammad Faiz wrote: > give very bad quality for soxr resampler. > linear_interp is intended for using linear interpolation > between filter bank so quality will be better. > > i guess this is misunderstood as 'do not use filter bank, > but directly inter

[FFmpeg-devel] [PATCH 1/2] swresample/soxr: fix invalid use of linear_interp

2016-11-25 Thread Muhammad Faiz
give very bad quality for soxr resampler. linear_interp is intended for using linear interpolation between filter bank so quality will be better. i guess this is misunderstood as 'do not use filter bank, but directly interpolate linearly between samples'. Signed-off-by: Muhammad Faiz --- libsw