Re: [FFmpeg-devel] [PATCH 1/3] avformat/flac_picture: Simplify checks

2019-12-01 Thread Michael Niedermayer
On Fri, Nov 29, 2019 at 08:44:09PM +0100, Andreas Rheinhardt wrote: > During parsing a flac picture metadata block, the mimetype is read as > follows: Its 32b size field is read and checked for being in the range > 1..63; afterwards, the actual mimetype-string is read into a buffer of > size 64,

[FFmpeg-devel] [PATCH 1/3] avformat/flac_picture: Simplify checks

2019-11-29 Thread Andreas Rheinhardt
During parsing a flac picture metadata block, the mimetype is read as follows: Its 32b size field is read and checked for being in the range 1..63; afterwards, the actual mimetype-string is read into a buffer of size 64, where the length to read is the minimum of the length field and the size of