Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-28 Thread Alex Smith
On Sun, Mar 20, 2016 at 6:29 AM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > > > I understand the sentiment, and there's probably little lost in > keeping it, but... is it not a hack? ie: > - When do you notice the added security is no longer there/it breaks > in even worse ways? >

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-20 Thread Christophe Gisquet
Hi, 2016-03-19 19:08 GMT+01:00 Ismail Donmez : >> 2016-03-11 8:57 GMT+01:00 Christophe Gisquet : It should either be reverted or made dependent on --enable/disable-debug (I would favor the first, honestly, since its a rather ugly hack

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-19 Thread Hendrik Leppkes
On Sat, Mar 12, 2016 at 3:09 AM, Michael Niedermayer wrote: > On Thu, Mar 10, 2016 at 07:57:53PM +0100, Hendrik Leppkes wrote: >> On Mon, Sep 21, 2015 at 6:41 AM, Alex Smith >> wrote: >> > From: Alex Smith >> > >> >

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-19 Thread Henrik Gramner
On Sat, Mar 19, 2016 at 7:25 PM, Hendrik Leppkes wrote: > Then tell that to binutils to actually produce proper binaries, and > not this broken mess that it produces now. https://sourceware.org/bugzilla/show_bug.cgi?id=19011 Doesn't seem like anything has happened since

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-19 Thread Hendrik Leppkes
On Sat, Mar 19, 2016 at 7:42 PM, Henrik Gramner wrote: > On Sat, Mar 19, 2016 at 7:25 PM, Hendrik Leppkes wrote: >> Then tell that to binutils to actually produce proper binaries, and >> not this broken mess that it produces now. > >

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-19 Thread Hendrik Leppkes
On Sat, Mar 19, 2016 at 7:08 PM, Ismail Donmez wrote: > On Sat, Mar 19, 2016 at 6:50 PM, Christophe Gisquet > wrote: >> Hi, >> >> 2016-03-11 8:57 GMT+01:00 Christophe Gisquet : It should either be reverted or made

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-19 Thread Ismail Donmez
On Sat, Mar 19, 2016 at 6:50 PM, Christophe Gisquet wrote: > Hi, > > 2016-03-11 8:57 GMT+01:00 Christophe Gisquet : >>> It should either be reverted or made dependent on >>> --enable/disable-debug (I would favor the first, honestly,

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-19 Thread Christophe Gisquet
2016-03-19 18:15 GMT+01:00 Hendrik Leppkes : > The same would need to be applied for the 32-bit case as well, fwiw. I didn't have a build environment to assert that, but now I do, and I confirm it is needed. Patch updated. -- Christophe From

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-19 Thread Hendrik Leppkes
On Sat, Mar 19, 2016 at 5:50 PM, Christophe Gisquet wrote: > Hi, > > 2016-03-11 8:57 GMT+01:00 Christophe Gisquet : >>> It should either be reverted or made dependent on >>> --enable/disable-debug (I would favor the first, honestly,

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-19 Thread Christophe Gisquet
Hi, 2016-03-11 8:57 GMT+01:00 Christophe Gisquet : >> It should either be reverted or made dependent on >> --enable/disable-debug (I would favor the first, honestly, since its a >> rather ugly hack in itself). > > At the very least, that dependence is needed, yes.

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-19 Thread Michael Niedermayer
On Fri, Mar 18, 2016 at 11:56:37AM +0100, Hendrik Leppkes wrote: > On Sat, Mar 12, 2016 at 3:09 AM, Michael Niedermayer > wrote: > > On Thu, Mar 10, 2016 at 07:57:53PM +0100, Hendrik Leppkes wrote: > >> On Mon, Sep 21, 2015 at 6:41 AM, Alex Smith

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-11 Thread Michael Niedermayer
On Thu, Mar 10, 2016 at 07:57:53PM +0100, Hendrik Leppkes wrote: > On Mon, Sep 21, 2015 at 6:41 AM, Alex Smith wrote: > > From: Alex Smith > > > > Binutils will always strip the relocation information from executable > > files even if it

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-11 Thread Hendrik Leppkes
On Fri, Mar 11, 2016 at 8:57 AM, Christophe Gisquet wrote: > Hi, > > 2016-03-10 19:57 GMT+01:00 Hendrik Leppkes : >> This patch (the relocations part) broke debugging mingw-w64 ffmpeg >> builds with gdb, you can't set breakpoints anymore when its

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-11 Thread Christophe Gisquet
Hi, 2016-03-10 19:57 GMT+01:00 Hendrik Leppkes : > This patch (the relocations part) broke debugging mingw-w64 ffmpeg > builds with gdb, you can't set breakpoints anymore when its applied. That issue prevented me to do anything interesting for ffmpeg since then, thinking it

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2016-03-10 Thread Hendrik Leppkes
On Mon, Sep 21, 2015 at 6:41 AM, Alex Smith wrote: > From: Alex Smith > > Binutils will always strip the relocation information from executable > files even if it needs it (dynamicbase/ASLR). We can work around this > by using the

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2015-09-22 Thread Alex Smith
On Tue, Sep 22, 2015 at 7:43 PM, Michael Niedermayer wrote: > > > this is ugly, but ASLR is important thus applied > i did not apply the nxcompat dynamicbase merge as its unrelated > > Thanks > > PS: if this breaks some version of mingw then this should be reverted > > [...] > >

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2015-09-22 Thread Michael Niedermayer
On Mon, Sep 21, 2015 at 12:41:36AM -0400, Alex Smith wrote: > From: Alex Smith > > Binutils will always strip the relocation information from executable > files even if it needs it (dynamicbase/ASLR). We can work around this > by using the pic-executable flag combined

Re: [FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2015-09-22 Thread Michael Niedermayer
On Tue, Sep 22, 2015 at 07:59:38PM -0400, Alex Smith wrote: > On Tue, Sep 22, 2015 at 7:43 PM, Michael Niedermayer > wrote: > > > > > > this is ugly, but ASLR is important thus applied > > i did not apply the nxcompat dynamicbase merge as its unrelated > > > > Thanks > > > > PS:

[FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section

2015-09-20 Thread Alex Smith
From: Alex Smith Binutils will always strip the relocation information from executable files even if it needs it (dynamicbase/ASLR). We can work around this by using the pic-executable flag combined with setting the correct entry point since apparently ld forgets what