Re: [FFmpeg-devel] [PATCH 1/3] lavu/attributes: introduce av_likely, av_unlikely

2016-02-27 Thread Ronald S. Bultje
Hi, On Sat, Feb 27, 2016 at 8:11 AM, Ganesh Ajjanagadde wrote: > On Thu, Feb 25, 2016 at 8:55 AM, Hendrik Leppkes > wrote: > > On Thu, Feb 25, 2016 at 8:27 AM, wm4 wrote: > >> On Thu, 25 Feb 2016 15:48:17 +1100 > >> Matt Oliver

Re: [FFmpeg-devel] [PATCH 1/3] lavu/attributes: introduce av_likely, av_unlikely

2016-02-27 Thread Ganesh Ajjanagadde
On Thu, Feb 25, 2016 at 8:55 AM, Hendrik Leppkes wrote: > On Thu, Feb 25, 2016 at 8:27 AM, wm4 wrote: >> On Thu, 25 Feb 2016 15:48:17 +1100 >> Matt Oliver wrote: >> >>> On 25 February 2016 at 13:20, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 1/3] lavu/attributes: introduce av_likely, av_unlikely

2016-02-25 Thread Hendrik Leppkes
On Thu, Feb 25, 2016 at 8:27 AM, wm4 wrote: > On Thu, 25 Feb 2016 15:48:17 +1100 > Matt Oliver wrote: > >> On 25 February 2016 at 13:20, Ganesh Ajjanagadde wrote: >> >> > From: Ganesh Ajjanagadde >> > >> >

Re: [FFmpeg-devel] [PATCH 1/3] lavu/attributes: introduce av_likely, av_unlikely

2016-02-25 Thread Derek Buitenhuis
On 2/25/2016 7:27 AM, wm4 wrote: > They also make code ugly as fuck, and are more cargo-cult than anything > else. They might possibly be ok in some very critical parts of the > code, but otherwise not at all. +1 to this. I will absolutely *not* ACK any patch sets that start littering

Re: [FFmpeg-devel] [PATCH 1/3] lavu/attributes: introduce av_likely, av_unlikely

2016-02-24 Thread wm4
On Thu, 25 Feb 2016 15:48:17 +1100 Matt Oliver wrote: > On 25 February 2016 at 13:20, Ganesh Ajjanagadde wrote: > > > From: Ganesh Ajjanagadde > > > > These use __builtin_expect, and may be useful for optimizing nearly > >

Re: [FFmpeg-devel] [PATCH 1/3] lavu/attributes: introduce av_likely, av_unlikely

2016-02-24 Thread Matt Oliver
On 25 February 2016 at 13:20, Ganesh Ajjanagadde wrote: > From: Ganesh Ajjanagadde > > These use __builtin_expect, and may be useful for optimizing nearly > certain branches, to yield size and/or speed improvements. > > Note that this is used in the

[FFmpeg-devel] [PATCH 1/3] lavu/attributes: introduce av_likely, av_unlikely

2016-02-24 Thread Ganesh Ajjanagadde
From: Ganesh Ajjanagadde These use __builtin_expect, and may be useful for optimizing nearly certain branches, to yield size and/or speed improvements. Note that this is used in the Linux kernel for the same purpose. For some idea as to potential benefits, see e.g