Re: [FFmpeg-devel] [PATCH 1/4] avformat/au: Store strings instead of pointers to strings in array

2020-07-20 Thread Andreas Rheinhardt
Alexander Strasser: > On 2020-07-19 23:38 +0200, Andreas Rheinhardt wrote: >> Alexander Strasser: > [...] >>> >>> On 2020-07-17 13:14 +0200, Andreas Rheinhardt wrote: Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/au.c | 13 ++--- > 1

Re: [FFmpeg-devel] [PATCH 1/4] avformat/au: Store strings instead of pointers to strings in array

2020-07-20 Thread Alexander Strasser
On 2020-07-19 23:38 +0200, Andreas Rheinhardt wrote: > Alexander Strasser: [...] > > > > On 2020-07-17 13:14 +0200, Andreas Rheinhardt wrote: > >> Andreas Rheinhardt: > >>> Signed-off-by: Andreas Rheinhardt > >>> --- > >>> libavformat/au.c | 13 ++--- > >>> 1 file changed, 6

Re: [FFmpeg-devel] [PATCH 1/4] avformat/au: Store strings instead of pointers to strings in array

2020-07-19 Thread Andreas Rheinhardt
Alexander Strasser: > Hi Andreas, > > no objections for the patchset as a whole. > > Just for the first in the series I have some questions. > > The commit message is: > > avformat/au: Store strings instead of pointers to strings in array > > This tells the what, but not the why. > I

Re: [FFmpeg-devel] [PATCH 1/4] avformat/au: Store strings instead of pointers to strings in array

2020-07-19 Thread Alexander Strasser
Hi Andreas, no objections for the patchset as a whole. Just for the first in the series I have some questions. The commit message is: avformat/au: Store strings instead of pointers to strings in array This tells the what, but not the why. On 2020-07-17 13:14 +0200, Andreas Rheinhardt

Re: [FFmpeg-devel] [PATCH 1/4] avformat/au: Store strings instead of pointers to strings in array

2020-07-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/au.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/libavformat/au.c b/libavformat/au.c > index f92863e400..b419c9ed95 100644 > --- a/libavformat/au.c > +++ b/libavformat/au.c >

[FFmpeg-devel] [PATCH 1/4] avformat/au: Store strings instead of pointers to strings in array

2020-07-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/au.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavformat/au.c b/libavformat/au.c index f92863e400..b419c9ed95 100644 --- a/libavformat/au.c +++ b/libavformat/au.c @@ -68,13 +68,13 @@ static int