Re: [FFmpeg-devel] [PATCH 1/4] avformat/mov: remove modulo operations from mov_estimate_video_delay()

2018-07-11 Thread Michael Niedermayer
On Wed, Jul 11, 2018 at 11:05:09AM -0700, Sasi Inguva wrote: > This one LGTM. Thanks for doing this. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wrong. signature.asc

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mov: remove modulo operations from mov_estimate_video_delay()

2018-07-11 Thread Sasi Inguva
This one LGTM. Thanks for doing this. On Tue, Jul 10, 2018 at 5:18 PM Michael Niedermayer wrote: > 0.324 <-0.491 sec > > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mov: remove modulo operations from mov_estimate_video_delay()

2018-07-11 Thread Carl Eugen Hoyos
2018-07-11 16:32 GMT+02:00, Derek Buitenhuis : > On Tue, Jul 10, 2018 at 8:17 PM, Michael Niedermayer > wrote: >> 0.324 <-0.491 sec >> >> Signed-off-by: Michael Niedermayer >> --- >> libavformat/mov.c | 10 +++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) > > All four of these

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mov: remove modulo operations from mov_estimate_video_delay()

2018-07-11 Thread Derek Buitenhuis
On Tue, Jul 10, 2018 at 8:17 PM, Michael Niedermayer wrote: > 0.324 <-0.491 sec > > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) All four of these patches combined bring the penalty down from 2-3x to ~1.19x,

[FFmpeg-devel] [PATCH 1/4] avformat/mov: remove modulo operations from mov_estimate_video_delay()

2018-07-10 Thread Michael Niedermayer
0.324 <-0.491 sec Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1346ffe480..aabf06de12 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3310,13