Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-04-06 Thread flow gg
Okay, updated it in the reply and github( https://github.com/hleft/FFmpeg/tree/vp8vp9) Rémi Denis-Courmont 于2024年4月4日周四 04:22写道: > Le torstaina 28. maaliskuuta 2024, 4.44.33 EEST flow gg a écrit : > > I don't quite understand, I think here 8x8 because zve64x is not suitable > > for sharing, it

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-04-03 Thread Rémi Denis-Courmont
Le torstaina 28. maaliskuuta 2024, 4.44.33 EEST flow gg a écrit : > I don't quite understand, I think here 8x8 because zve64x is not suitable > for sharing, it shares between dc16x16 and dc32x32, there isn't much common > code, it would require adding 3 if-else statements and function parameters,

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-27 Thread flow gg
I don't quite understand, I think here 8x8 because zve64x is not suitable for sharing, it shares between dc16x16 and dc32x32, there isn't much common code, it would require adding 3 if-else statements and function parameters, it feels okay not to extract too. Rémi Denis-Courmont 于2024年3月27日周三

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-27 Thread Rémi Denis-Courmont
Le perjantaina 22. maaliskuuta 2024, 8.02.08 EET flow gg a écrit : > Using macros to shorten function definitions, updated in this response Did you try to share the common code after getdc and see how slower it is? If an extra static branch has negligible overhead, it would reduce binary size

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-22 Thread flow gg
Using macros to shorten function definitions, updated in this response flow gg 于2024年3月7日周四 19:20写道: > updated it in the reply > > flow gg 于2024年3月3日周日 23:31写道: > >> > As noted eaerlier, I don't understand why you have two size parameters. >> It >> seems that \size is always either the same as

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-07 Thread flow gg
updated it in the reply flow gg 于2024年3月3日周日 23:31写道: > > As noted eaerlier, I don't understand why you have two size parameters. > It > seems that \size is always either the same as (1 << (\size2 - 1)) a.k.a. > ((1 > << \size2) / 2), or unused. The assembler *can* compute arithmetic >

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-03 Thread flow gg
> As noted eaerlier, I don't understand why you have two size parameters. It seems that \size is always either the same as (1 << (\size2 - 1)) a.k.a. ((1 << \size2) / 2), or unused. The assembler *can* compute arithmetic constants. Thanks , I didn't know that before > Similarly, you can use

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-03 Thread Rémi Denis-Courmont
Le sunnuntaina 3. maaliskuuta 2024, 3.59.00 EET flow gg a écrit : > updated a little improve in this reply As noted eaerlier, I don't understand why you have two size parameters. It seems that \size is always either the same as (1 << (\size2 - 1)) a.k.a. ((1 << \size2) / 2), or unused. The

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-02 Thread flow gg
updated a little improve in this reply flow gg 于2024年3月2日周六 17:48写道: > Okay, reduced if/else in the response. > > Rémi Denis-Courmont 于2024年3月2日周六 17:03写道: > >> Le lauantaina 2. maaliskuuta 2024, 9.42.06 EET flow gg a écrit : >> > >> >> You would need a lot fewer if/else if you passed the

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-02 Thread flow gg
Okay, reduced if/else in the response. Rémi Denis-Courmont 于2024年3月2日周六 17:03写道: > Le lauantaina 2. maaliskuuta 2024, 9.42.06 EET flow gg a écrit : > > > > You would need a lot fewer if/else if you passed the order/bit-width > instead > of the size as macro parameter. > > Similarly, this can be

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-02 Thread Rémi Denis-Courmont
Le lauantaina 2. maaliskuuta 2024, 9.42.06 EET flow gg a écrit : > You would need a lot fewer if/else if you passed the order/bit-width instead of the size as macro parameter. Similarly, this can be folded as a single .else: +.elseif \type == 127 +li t1, 127 +.elseif \type

[FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-01 Thread flow gg
From adaae06a3e18bccec1772a3134334cbea652ae77 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Mon, 26 Feb 2024 14:42:17 +0800 Subject: [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc C908: vp9_dc_8x8_8bpp_c: 46.0 vp9_dc_8x8_8bpp_rvv_i64: 41.0 vp9_dc_16x16_8bpp_c: 109.2 vp9_dc_16x16_8bpp_rvv_i32: 72.7