Re: [FFmpeg-devel] [PATCH 1/6] avcodec/aacdec_template: Check samplerate

2019-10-10 Thread Michael Niedermayer
On Thu, Oct 10, 2019 at 12:06:43PM +0200, Moritz Barsnick wrote: > On Wed, Oct 09, 2019 at 12:14:49 +0200, Michael Niedermayer wrote: > > +if (avctx->sample_rate > INT_MAX/2) > > +return AVERROR_INVALIDDATA; > > Who enforces the defined sample rates? The demuxer? > > I'm trying to say

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/aacdec_template: Check samplerate

2019-10-10 Thread Moritz Barsnick
On Wed, Oct 09, 2019 at 12:14:49 +0200, Michael Niedermayer wrote: > +if (avctx->sample_rate > INT_MAX/2) > +return AVERROR_INVALIDDATA; Who enforces the defined sample rates? The demuxer? I'm trying to say: The maxmimum for AAC is 96000, why not use that? (Will it ever change? Can it

[FFmpeg-devel] [PATCH 1/6] avcodec/aacdec_template: Check samplerate

2019-10-09 Thread Michael Niedermayer
A value above INT_MAX/2 can overflow in SBR Fixes: signed integer overflow: 2 * 1881153568 cannot be represented in type 'int' Fixes: 17996/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5687126468853760 Found-by: continuous fuzzing process https://github.com/google/oss-fuz