Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_amerge: do not guess an output channel layout

2016-12-23 Thread Michael Niedermayer
On Fri, Dec 23, 2016 at 03:12:26PM +0100, Nicolas George wrote: > Le quintidi 25 frimaire, an CCXXV, Marton Balint a écrit : [...] > > --- a/tests/ref/fate/filter-amerge > > +++ b/tests/ref/fate/filter-amerge > > @@ -2,8 +2,8 @@ > > #media_type 0: audio > > #codec_id 0: pcm_s16le > >

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_amerge: do not guess an output channel layout

2016-12-23 Thread Nicolas George
Le quintidi 25 frimaire, an CCXXV, Marton Balint a écrit : > This is the right thing to do, but I am afraid this will break too many > existing filter chains. How can we implement this properly? Ideas/options: > > - change it, break it, users will fix it > - add a guess_output_layout option which

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_amerge: do not guess an output channel layout

2016-12-23 Thread Michael Niedermayer
On Thu, Dec 15, 2016 at 04:39:19AM +0100, Marton Balint wrote: > This is the right thing to do, but I am afraid this will break too many > existing filter chains. How can we implement this properly? Ideas/options: do you have an example of a filter chain it would break ? [...] -- Michael

[FFmpeg-devel] [PATCH 2/2] avfilter/af_amerge: do not guess an output channel layout

2016-12-14 Thread Marton Balint
This is the right thing to do, but I am afraid this will break too many existing filter chains. How can we implement this properly? Ideas/options: - change it, break it, users will fix it - add a guess_output_layout option which will be true for now, false after a major bump, and mention this