On Sun, Jun 09, 2019 at 11:26:14AM +0200, Stephan Hilb wrote:
> > Repeated messages only get supressed if there is no interspaced
> > message if 2 things generate a message per frame, neither will be
> > supressed
>
> So should I leave it at DEBUG level or implement a custom log_once?
i agree
> Repeated messages only get supressed if there is no interspaced
> message if 2 things generate a message per frame, neither will be
> supressed
So should I leave it at DEBUG level or implement a custom log_once?
The "cur_dts invalid" debug message is currently being printed at least
as often.
On Fri, Jun 07, 2019 at 10:35:03PM +0200, Stephan Hilb wrote:
> >> -!ost->copy_initial_nonkeyframes)
> >> +!ost->copy_initial_nonkeyframes) {
> >> +av_log(NULL, AV_LOG_DEBUG, "skipping initial
> >> non-keyframe\n"); return;
> >
> > Incorrect indentation.
>
> It's
On Fri, Jun 07, 2019 at 22:35:03 +0200, Stephan Hilb wrote:
> > Incorrect indentation.
>
> It's actually the same indentation as in other places in the same file,
> what would be the correct way then?
Sorry, my mind went flaky, you're corrent.
> > I suggest this message should be at INFO level,
>> -!ost->copy_initial_nonkeyframes)
>> +!ost->copy_initial_nonkeyframes) {
>> +av_log(NULL, AV_LOG_DEBUG, "skipping initial
>> non-keyframe\n"); return;
>
> Incorrect indentation.
It's actually the same indentation as in other places in the same file,
what would be the
On Thu, Jun 06, 2019 at 22:31:45 +0200, Stephan Hilb wrote:
> If `AV_PKT_FLAG_KEY` stays unset on `pkt->flags`, the output stream
> stays empty with little information about what is going on.
> This change makes it easier to debug the situation for the user who
> could then choose to use the
On Thu, Jun 06, 2019 at 10:31:45PM +0200, Stephan Hilb wrote:
> If `AV_PKT_FLAG_KEY` stays unset on `pkt->flags`, the output stream
> stays empty with little information about what is going on.
> This change makes it easier to debug the situation for the user who
> could then choose to use the
If `AV_PKT_FLAG_KEY` stays unset on `pkt->flags`, the output stream
stays empty with little information about what is going on.
This change makes it easier to debug the situation for the user who
could then choose to use the `-copyinkf` option.
---
fftools/ffmpeg.c | 4 +++-
1 file changed, 3
