Re: [FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

2020-07-09 Thread Zlomek, Josef
On Thu, Jul 9, 2020 at 11:44 AM Nicolas George wrote: > Josef Zlomek (12020-07-08): > > > +@item min_delay > > +Set the minimum valid delay between frames in milliseconds. > > +Range is 0 to 6. Default value is 10. > > + > > +@item max_webp_delay > > +Set the maximum valid delay between

Re: [FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

2020-07-09 Thread Pascal Massimino
Hi, On Thu, Jul 9, 2020 at 11:44 AM Nicolas George wrote: > Josef Zlomek (12020-07-08): > > Fixes: 4907 > > > > Adds support for demuxing of animated WebP. > > > > The WebP demuxer splits the input stream into packets containing one > frame. > > It also sets the timing information properly. > >

Re: [FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

2020-07-09 Thread Nicolas George
Josef Zlomek (12020-07-08): > Fixes: 4907 > > Adds support for demuxing of animated WebP. > > The WebP demuxer splits the input stream into packets containing one frame. > It also sets the timing information properly. Thanks for the patch. A few comments. > > Signed-off-by: Josef Zlomek >

Re: [FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

2020-07-09 Thread Zlomek, Josef
On Wed, Jul 8, 2020 at 10:04 AM Steven Liu wrote: > > (base) liuqi05:dash liuqi$ ./ffplay_g test.webp > [...] > Segmentation fault: 11 > (base) liuqi05:dash liuqi$ > The segfault was caused by the usage of unaligned buffers for frames. When using aligned buffers, it does not crash anymore.

Re: [FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

2020-07-09 Thread Zlomek, Josef
On Wed, Jul 8, 2020 at 10:34 PM Carl Eugen Hoyos wrote: > Am Mi., 8. Juli 2020 um 07:28 Uhr schrieb Josef Zlomek : > > > > Fixes: 4907 > > It seems surprising that two commits should fix a ticket. > My understanding of ffmpeg internals is limited: The parser is used for input from a pipe, the

Re: [FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

2020-07-08 Thread Carl Eugen Hoyos
Am Mi., 8. Juli 2020 um 07:28 Uhr schrieb Josef Zlomek : > > Fixes: 4907 It seems surprising that two commits should fix a ticket. > Adds support for demuxing of animated WebP. Does this demuxer also support single frame files? What about concatenated webps? [...] > +static int

[FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

2020-07-07 Thread Josef Zlomek
Fixes: 4907 Adds support for demuxing of animated WebP. The WebP demuxer splits the input stream into packets containing one frame. It also sets the timing information properly. Signed-off-by: Josef Zlomek --- Changelog| 1 + doc/demuxers.texi| 28