Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2019-01-30 Thread Michael Niedermayer
On Thu, Jan 17, 2019 at 09:45:04PM +, Derek Buitenhuis wrote: > On 15/01/2019 21:24, Michael Niedermayer wrote: > > Heres a better patch which may work with seeking as long as there are only > > 2 files concatenated > > > > i think completely discarding the parts after the concatenation would

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2019-01-17 Thread Derek Buitenhuis
On 15/01/2019 21:24, Michael Niedermayer wrote: > Heres a better patch which may work with seeking as long as there are only > 2 files concatenated > > i think completely discarding the parts after the concatenation would cause > user complaints and they would have a point, if the data is in

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2019-01-15 Thread Michael Niedermayer
On Thu, Jan 03, 2019 at 04:21:37PM +, Derek Buitenhuis wrote: > On 03/01/2019 01:33, Michael Niedermayer wrote: > > The file looks like 2 files concatenated, even with FLV main header between > > them. > > Yes, they all seem to be. I was under the impression FLV didn't have a header > to >

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2019-01-03 Thread Derek Buitenhuis
On 03/01/2019 01:33, Michael Niedermayer wrote: > The file looks like 2 files concatenated, even with FLV main header between > them. Yes, they all seem to be. I was under the impression FLV didn't have a header to check against like this. Seems I was wrong. > the patch below should make this

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2019-01-02 Thread Michael Niedermayer
On Mon, Nov 26, 2018 at 01:51:25PM +, Derek Buitenhuis wrote: > On 23/11/2018 02:16, Michael Niedermayer wrote: > > do we have some sample flv files that require this patchset / that have > > discontinuites. > > I have many. I've mailed you one privately, while I work on getting a public >

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2019-01-02 Thread Derek Buitenhuis
On 24/12/2018 16:42, Derek Buitenhuis wrote: > Ping. Is there a decision on eitehr what to do or to ignore this? > > I'll update my downstream code with an FLV edge case if need be. Ping. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-12-24 Thread Derek Buitenhuis
On 26/11/2018 13:51, Derek Buitenhuis wrote: > On 23/11/2018 02:16, Michael Niedermayer wrote: >> do we have some sample flv files that require this patchset / that have >> discontinuites. > > I have many. I've mailed you one privately, while I work on getting a public > one. > >> another thing

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-26 Thread Derek Buitenhuis
On 23/11/2018 02:16, Michael Niedermayer wrote: > do we have some sample flv files that require this patchset / that have > discontinuites. I have many. I've mailed you one privately, while I work on getting a public one. > another thing i just realize now, why is this discontinuity issues

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-22 Thread Michael Niedermayer
On Thu, Nov 22, 2018 at 10:27:18AM +, Derek Buitenhuis wrote: > On 22/11/2018 02:16, Michael Niedermayer wrote: > > the specification says this: > > "Timestamp UI24 Time in milliseconds at which the data in this tag > > applies. This is relative to the first tag in the FLV

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-22 Thread Michael Niedermayer
On Thu, Nov 22, 2018 at 07:18:04PM +0200, Jan Ekström wrote: > On Thu, Nov 22, 2018 at 4:17 AM Michael Niedermayer > wrote: > > > > On Wed, Nov 21, 2018 at 03:58:47PM +, Derek Buitenhuis wrote: > > > Any FLV file, not necessarily valid, but in extremely common use for live > > > or archived

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-22 Thread Jan Ekström
On Thu, Nov 22, 2018 at 4:17 AM Michael Niedermayer wrote: > > On Wed, Nov 21, 2018 at 03:58:47PM +, Derek Buitenhuis wrote: > > Any FLV file, not necessarily valid, but in extremely common use for live > > or archived live purposes, may output discontinuous timestamps. As it > > currently >

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-22 Thread Derek Buitenhuis
On 22/11/2018 12:55, Carl Eugen Hoyos wrote: > Only the downstreams that expect invalid files, no? It's the generic way to handle containers which can have discontinuous timestamps. Nothing to do with expecting invalid files. Cheers, - Derek ___

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-22 Thread Carl Eugen Hoyos
2018-11-22 11:27 GMT+01:00, Derek Buitenhuis : > Every downstream codebase that cares could force the 'live_flv' > demuxer for all FLVs, but this seems ugly and needlessly special cased. Only the downstreams that expect invalid files, no? No opinion here about the patch, Carl Eugen

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-22 Thread Derek Buitenhuis
On 22/11/2018 02:16, Michael Niedermayer wrote: > the specification says this: > "Timestamp UI24 Time in milliseconds at which the data in this tag > applies. This is relative to the first tag in the FLV file, > which always has a timestamp of 0. > " > So flv does

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-21 Thread Michael Niedermayer
On Wed, Nov 21, 2018 at 03:58:47PM +, Derek Buitenhuis wrote: > Any FLV file, not necessarily valid, but in extremely common use for live > or archived live purposes, may output discontinuous timestamps. As it > currently > is, only files produced by NGINX's RTMP module will be marked as

[FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-21 Thread Derek Buitenhuis
Any FLV file, not necessarily valid, but in extremely common use for live or archived live purposes, may output discontinuous timestamps. As it currently is, only files produced by NGINX's RTMP module will be marked as supporting discontinuous timestamps, which is obviously untrue, and the fix was