Re: [FFmpeg-devel] [PATCH 2/4] lavc/audiotoolboxenc: fix a number of config issues

2016-03-24 Thread Rodger Combs
> On Mar 24, 2016, at 06:25, Michael Niedermayer wrote: > > On Thu, Mar 24, 2016 at 12:54:07AM -0500, Rodger Combs wrote: >> >> +AudioValueRange *ranges = malloc(size); >> +if (!ranges) > > is it intended to use malloc() instead of av_malloc()

Re: [FFmpeg-devel] [PATCH 2/4] lavc/audiotoolboxenc: fix a number of config issues

2016-03-24 Thread Michael Niedermayer
On Thu, Mar 24, 2016 at 12:54:07AM -0500, Rodger Combs wrote: > - size variables were used in a confusing way > - incorrect size var use led to channel layouts not being set properly > - channel layouts were incorrectly mapped for >2-channel AAC > - bitrates not accepted by the encoder were

[FFmpeg-devel] [PATCH 2/4] lavc/audiotoolboxenc: fix a number of config issues

2016-03-24 Thread Rodger Combs
- size variables were used in a confusing way - incorrect size var use led to channel layouts not being set properly - channel layouts were incorrectly mapped for >2-channel AAC - bitrates not accepted by the encoder were discarded instead of being clamped - some minor style/indentation fixes ---