Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-25 Thread Ganesh Ajjanagadde
On Sun, Oct 25, 2015 at 12:35 PM, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 09:03:03PM -0400, Ganesh Ajjanagadde wrote: >> On Sat, Oct 24, 2015 at 7:17 PM, Henrik Gramner wrote: >> > On Sun, Oct 25, 2015 at 12:02 AM, Ganesh Ajjanagadde >> >

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-25 Thread Michael Niedermayer
On Sun, Oct 25, 2015 at 12:46:31PM -0400, Ganesh Ajjanagadde wrote: > On Sun, Oct 25, 2015 at 12:35 PM, Michael Niedermayer > wrote: > > On Sat, Oct 24, 2015 at 09:03:03PM -0400, Ganesh Ajjanagadde wrote: > >> On Sat, Oct 24, 2015 at 7:17 PM, Henrik Gramner

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-25 Thread Ganesh Ajjanagadde
On Sun, Oct 25, 2015 at 1:03 PM, Michael Niedermayer wrote: > On Sun, Oct 25, 2015 at 12:46:31PM -0400, Ganesh Ajjanagadde wrote: >> On Sun, Oct 25, 2015 at 12:35 PM, Michael Niedermayer >> wrote: >> > On Sat, Oct 24, 2015 at 09:03:03PM -0400,

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-25 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 09:03:03PM -0400, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 7:17 PM, Henrik Gramner wrote: > > On Sun, Oct 25, 2015 at 12:02 AM, Ganesh Ajjanagadde > > wrote: > >> -static int cmp(void *key, const void *node) > >>

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 7:17 PM, Henrik Gramner wrote: > On Sun, Oct 25, 2015 at 12:02 AM, Ganesh Ajjanagadde > wrote: >> -static int cmp(void *key, const void *node) >> +static int cmp(const void *key, const void *node) >> { >> return (*(int64_t

[FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-24 Thread Ganesh Ajjanagadde
libc's qsort comparator has a const qualifier on both arguments. This adds a missing const qualifier to exactly match the comparator API. Existing usages of av_tree_find, av_tree_insert are appropriately modified: type signature changes of the comparators, and removal of unnecessary void * casts

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-24 Thread Henrik Gramner
On Sun, Oct 25, 2015 at 12:02 AM, Ganesh Ajjanagadde wrote: > -static int cmp(void *key, const void *node) > +static int cmp(const void *key, const void *node) > { > return (*(int64_t *) key) - ((const CacheEntry *) node)->logical_pos; > } > -int