Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_refs: Rewrite code to make control flow clearer

2024-03-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > While this change IMO makes the control flow clearer > for the human reader, it is especially important for > GCC: It erroneously believes that it is possible to > enter the SHORT2(UNUSED|LONG) cases without having > entered the preceding block that initializes pic, > frame_nu

[FFmpeg-devel] [PATCH 3/6] avcodec/h264_refs: Rewrite code to make control flow clearer

2024-03-26 Thread Andreas Rheinhardt
While this change IMO makes the control flow clearer for the human reader, it is especially important for GCC: It erroneously believes that it is possible to enter the SHORT2(UNUSED|LONG) cases without having entered the preceding block that initializes pic, frame_num, structure and j; it would emi