Re: [FFmpeg-devel] [PATCH 4/4] huffyuvencdsp: Add ff_diff_bytes_avx2

2015-10-19 Thread Ganesh Ajjanagadde
On Mon, Oct 19, 2015 at 4:00 PM, Timothy Gu wrote: > About 16% faster on large clips (>1200px width), more than 2x slower on small > clips > (352px). So using a heuristic to select with one to use. What system, what compiler, etc? Without any such information, numbers are

[FFmpeg-devel] [PATCH 4/4] huffyuvencdsp: Add ff_diff_bytes_avx2

2015-10-19 Thread Timothy Gu
About 16% faster on large clips (>1200px width), more than 2x slower on small clips (352px). So using a heuristic to select with one to use. --- libavcodec/huffyuvenc.c| 6 +++--- libavcodec/huffyuvencdsp.c | 4 ++-- libavcodec/huffyuvencdsp.h | 4 ++--

Re: [FFmpeg-devel] [PATCH 4/4] huffyuvencdsp: Add ff_diff_bytes_avx2

2015-10-19 Thread Hendrik Leppkes
On Mon, Oct 19, 2015 at 10:36 PM, Ganesh Ajjanagadde wrote: > On Mon, Oct 19, 2015 at 4:00 PM, Timothy Gu wrote: >> About 16% faster on large clips (>1200px width), more than 2x slower on >> small clips >> (352px). So using a heuristic to select with one

Re: [FFmpeg-devel] [PATCH 4/4] huffyuvencdsp: Add ff_diff_bytes_avx2

2015-10-19 Thread Ganesh Ajjanagadde
On Mon, Oct 19, 2015 at 4:41 PM, Hendrik Leppkes wrote: > On Mon, Oct 19, 2015 at 10:36 PM, Ganesh Ajjanagadde wrote: >> On Mon, Oct 19, 2015 at 4:00 PM, Timothy Gu wrote: >>> About 16% faster on large clips (>1200px width), more

Re: [FFmpeg-devel] [PATCH 4/4] huffyuvencdsp: Add ff_diff_bytes_avx2

2015-10-19 Thread Henrik Gramner
On Mon, Oct 19, 2015 at 10:00 PM, Timothy Gu wrote: > About 16% faster on large clips (>1200px width), more than 2x slower on small > clips > (352px). The reason is for this is likely the fact that you fall back to scalar as soon as you have less than 2*mmsize bytes left

Re: [FFmpeg-devel] [PATCH 4/4] huffyuvencdsp: Add ff_diff_bytes_avx2

2015-10-19 Thread Timothy Gu
On Mon, Oct 19, 2015 at 1:44 PM Ganesh Ajjanagadde wrote: > On Mon, Oct 19, 2015 at 4:41 PM, Hendrik Leppkes > wrote: > > On Mon, Oct 19, 2015 at 10:36 PM, Ganesh Ajjanagadde > wrote: > >> On Mon, Oct 19, 2015 at 4:00 PM, Timothy Gu