Re: [FFmpeg-devel] [PATCH 4/4] zmbvenc: use unsigned values for score calculations

2018-12-25 Thread Tomas Härdin
lör 2018-12-22 klockan 15:54 + skrev Matthew Fearnley: > > On 22 Dec 2018, at 12:15, Tomas Härdin wrote: > > > > tor 2018-12-20 klockan 17:48 + skrev Matthew Fearnley: > > > > > > On Thu, 20 Dec 2018 at 16:30, Tomas Härdin > > > > > .se> wrote: > > > > > > > > Trivial enough. You could

Re: [FFmpeg-devel] [PATCH 4/4] zmbvenc: use unsigned values for score calculations

2018-12-22 Thread Matthew Fearnley
> On 22 Dec 2018, at 12:15, Tomas Härdin wrote: > > tor 2018-12-20 klockan 17:48 + skrev Matthew Fearnley: > On Thu, 20 Dec 2018 at 16:30, Tomas Härdin wrote: >>> >>> Trivial enough. You could probably roll many or even all of these >>> patches together >> >> Thanks for your

Re: [FFmpeg-devel] [PATCH 4/4] zmbvenc: use unsigned values for score calculations

2018-12-22 Thread Tomas Härdin
tor 2018-12-20 klockan 17:48 + skrev Matthew Fearnley: > > On Thu, 20 Dec 2018 at 16:30, Tomas Härdin wrote: > > > Trivial enough. You could probably roll many or even all of these > > patches together > > > > Thanks for your feedback.  I was reluctant to submit so many patches, but I >

Re: [FFmpeg-devel] [PATCH 4/4] zmbvenc: use unsigned values for score calculations

2018-12-20 Thread Matthew Fearnley
On Thu, 20 Dec 2018 at 16:30, Tomas Härdin wrote: > Trivial enough. You could probably roll many or even all of these > patches together > Thanks for your feedback. I was reluctant to submit so many patches, but I worried at the time that combining them would require an overly long commit

Re: [FFmpeg-devel] [PATCH 4/4] zmbvenc: use unsigned values for score calculations

2018-12-20 Thread Tomas Härdin
ons 2018-12-19 klockan 22:00 + skrev matthew.w.fearn...@gmail.com: > > From: Matthew Fearnley > > All the values in score_tab are positive or 0, and so should be the sum > returned by block_cmp(). > > The logic in zmbv_me() assumes that all 'bv' values will be non-negative, > in order to

[FFmpeg-devel] [PATCH 4/4] zmbvenc: use unsigned values for score calculations

2018-12-19 Thread matthew . w . fearnley
From: Matthew Fearnley All the values in score_tab are positive or 0, and so should be the sum returned by block_cmp(). The logic in zmbv_me() assumes that all 'bv' values will be non-negative, in order to guarantee an early return if ever bv==0. --- libavcodec/zmbvenc.c | 7 --- 1 file