Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2020-01-28 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 01:28:39AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (70sec -> 243ms) > Fixes: > 16097/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5664690889293824 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/project

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2019-09-02 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 11:04:20AM +0200, Paul B Mahol wrote: > On Sun, Aug 18, 2019 at 10:25 AM Michael Niedermayer > wrote: > > > On Sun, Aug 18, 2019 at 09:21:25AM +0200, Paul B Mahol wrote: > > > NAK > > > > What problem do you see in this patch ? > > > > What change do you suggest ? > > or w

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2019-08-18 Thread Paul B Mahol
On Sun, Aug 18, 2019 at 10:25 AM Michael Niedermayer wrote: > On Sun, Aug 18, 2019 at 09:21:25AM +0200, Paul B Mahol wrote: > > NAK > > What problem do you see in this patch ? > > What change do you suggest ? > or what alternative fix for the issue do you suggest ? > > a DOS issue in png will hav

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2019-08-18 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 09:21:25AM +0200, Paul B Mahol wrote: > NAK What problem do you see in this patch ? What change do you suggest ? or what alternative fix for the issue do you suggest ? a DOS issue in png will have to be fixed, otherwise major users would have to use different libraries fo

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2019-08-18 Thread Paul B Mahol
NAK On Sun, Aug 18, 2019 at 1:36 AM Michael Niedermayer wrote: > Fixes: Timeout (70sec -> 243ms) > Fixes: > 16097/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5664690889293824 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmp

[FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2019-08-17 Thread Michael Niedermayer
Fixes: Timeout (70sec -> 243ms) Fixes: 16097/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5664690889293824 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pngdec.c | 12 ++