Re: [FFmpeg-devel] [PATCH 4/6] avformat/wavdec: s337m support

2023-02-22 Thread Tomas Härdin
tis 2023-02-21 klockan 12:30 + skrev Nicolas Gaullier: > > This is why it is better to demand that these things be explicitly > > signalled. At the same time a lot of users expect ffmpeg to Just > > Work, but that is not always possible. Perhaps we should should put > > this in the manual and

Re: [FFmpeg-devel] [PATCH 4/6] avformat/wavdec: s337m support

2023-02-21 Thread Nicolas Gaullier
>This is why it is better to demand that these things be explicitly signalled. >At the same time a lot of users expect ffmpeg to Just Work, but that is not >always possible. Perhaps we should should put this in the manual and tell >>spdif/s377m/dolby-e users to RTFM? > >> And another point here

Re: [FFmpeg-devel] [PATCH 4/6] avformat/wavdec: s337m support

2023-02-21 Thread Tomas Härdin
fre 2023-02-17 klockan 10:30 + skrev Nicolas Gaullier: > > > +#if CONFIG_S337M_DEMUXER > > > +    {"non_pcm_mode", "Chooses what to do with s337m", > > > OFFSET(non_pcm_mode), AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, DEC, > > > "non_pcm_mode"}, > > > +    {"copy"    , "Pass s337m through

Re: [FFmpeg-devel] [PATCH 4/6] avformat/wavdec: s337m support

2023-02-17 Thread Nicolas Gaullier
>> +#if CONFIG_S337M_DEMUXER >> +    {"non_pcm_mode", "Chooses what to do with s337m", >> OFFSET(non_pcm_mode), AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, DEC, >> "non_pcm_mode"}, >> +    {"copy"    , "Pass s337m through unchanged", 0, >> AV_OPT_TYPE_CONST, {.i64 = 0}, 0, 1, DEC, "non_pcm_mode"}, >>

Re: [FFmpeg-devel] [PATCH 4/6] avformat/wavdec: s337m support

2023-02-16 Thread Tomas Härdin
mån 2023-02-13 klockan 19:09 +0100 skrev Nicolas Gaullier: > +#if CONFIG_S337M_DEMUXER > +    {"non_pcm_mode", "Chooses what to do with s337m", > OFFSET(non_pcm_mode), AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, DEC, > "non_pcm_mode"}, > +    {"copy"    , "Pass s337m through unchanged", 0, >

[FFmpeg-devel] [PATCH 4/6] avformat/wavdec: s337m support

2023-02-13 Thread Nicolas Gaullier
Add s337m probing and demuxing similarly to spdif. Add 'non_pcm_mode' option to disable s337m demuxing (pass-through). --- libavformat/wavdec.c | 47 +++- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/libavformat/wavdec.c