Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2018-01-05 Thread Devin Heitmueller
Hi Aaron, >> +static int create_s337_payload(AVPacket *pkt, enum AVCodecID codec_id, >> uint8_t **outbuf, int *outsize) >> +{ >> +uint8_t *s337_payload; >> +uint8_t *s337_payload_start; >> +int i; >> + >> +/* Encapsulate AC3 syncframe into SMPTE 337 packet */ >> +*outsize = (

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2017-12-30 Thread Aaron Levinson
On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Extend the decklink output to include support for compressed AC-3, encapsulated using the SMPTE ST 377:2015 standard. This functionality can be exercised by using the "copy" codec when the input audio stream is AC-3. For example: ./ffmpeg -i ~/f

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2017-12-29 Thread Devin Heitmueller
> On Dec 29, 2017, at 3:59 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > >> +uint8_t *outbuf = NULL; > >> +if (st->codecpar->codec_id == AV_CODEC_ID_AC3) >> +av_free(outbuf); > > The "if()" should not be necessary, free() and av_free() > may

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2017-12-29 Thread Carl Eugen Hoyos
2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > +uint8_t *outbuf = NULL; > +if (st->codecpar->codec_id == AV_CODEC_ID_AC3) > +av_free(outbuf); The "if()" should not be necessary, free() and av_free() may be called with argument "NULL". Carl Eugen ___

[FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2017-12-29 Thread Devin Heitmueller
Extend the decklink output to include support for compressed AC-3, encapsulated using the SMPTE ST 377:2015 standard. This functionality can be exercised by using the "copy" codec when the input audio stream is AC-3. For example: ./ffmpeg -i ~/foo.ts -codec:a copy -f decklink 'UltraStudio Mini M