Re: [FFmpeg-devel] [PATCH v12 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-10 Thread Nick Renieris
> Why do you put all this color space convertion code into the decoders ? The color space conversion needs to happen, camera sensor data is linear. If it's not done images looks really dark as result. > Colorspace and pixel format convertion is generally done outside decoders. > The

Re: [FFmpeg-devel] [PATCH v12 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-10 Thread Nicolas George
Paul B Mahol (12019-08-10): > It is part of DNG specification. Do you want to not follow DNG > specification? The specification cannot specify what part of FFmpeg's code does the conversion. -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH v12 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-10 Thread Paul B Mahol
On Sat, Aug 10, 2019 at 2:42 PM Michael Niedermayer wrote: > On Fri, Aug 09, 2019 at 07:29:48PM +0300, Nick Renieris wrote: > > From: Nick Renieris > > > > Signed-off-by: Nick Renieris > > --- > > libavcodec/tiff.c | 34 +++--- > > 1 file changed, 23 insertions(+),

Re: [FFmpeg-devel] [PATCH v12 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-10 Thread Michael Niedermayer
On Fri, Aug 09, 2019 at 07:29:48PM +0300, Nick Renieris wrote: > From: Nick Renieris > > Signed-off-by: Nick Renieris > --- > libavcodec/tiff.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c >

[FFmpeg-devel] [PATCH v12 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-09 Thread Nick Renieris
From: Nick Renieris Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index d5673abb19..a118c37c41 100644 --- a/libavcodec/tiff.c +++