Re: [FFmpeg-devel] [PATCH v2] Fix sdp size check on fmtp integer parameters

2019-04-18 Thread Michael Niedermayer
On Mon, Apr 01, 2019 at 04:45:38PM +0200, Olivier Maignial wrote: > RFC-4566 do not give any limit of size on interger parameters given in fmtp > line. > By reading some more RFCs it is possible to find examples where some integers > parameters are greater than 32 (see RFC-6416, 7.4) > >

Re: [FFmpeg-devel] [PATCH v2] Fix sdp size check on fmtp integer parameters

2019-04-17 Thread Olivier MAIGNIAL
Hello all Just a reminder for this patch On Mon, Apr 1, 2019 at 4:45 PM Olivier Maignial wrote: > RFC-4566 do not give any limit of size on interger parameters given in > fmtp line. > By reading some more RFCs it is possible to find examples where some > integers parameters are greater than 32

[FFmpeg-devel] [PATCH v2] Fix sdp size check on fmtp integer parameters

2019-04-01 Thread Olivier Maignial
RFC-4566 do not give any limit of size on interger parameters given in fmtp line. By reading some more RFCs it is possible to find examples where some integers parameters are greater than 32 (see RFC-6416, 7.4) Instead I propose to check just check the eventual integer overflow. Using INT_MIN