Re: [FFmpeg-devel] [PATCH v2] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-06-17 Thread Romane Lafon
Hello, Thank you for your feedback. I made a third version of my patch. Regards, Romane Le lun. 27 mai 2019 à 21:07, Moritz Barsnick a écrit : > On Mon, May 20, 2019 at 14:40:24 +0200, Romane Lafon wrote: > > +float tolerance = 1.0 - s->tolerance; > > Strictly speaking 1.0f (or 1.f). > > >

Re: [FFmpeg-devel] [PATCH v2] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-05-27 Thread Moritz Barsnick
On Mon, May 20, 2019 at 14:40:24 +0200, Romane Lafon wrote: > +float tolerance = 1.0 - s->tolerance; Strictly speaking 1.0f (or 1.f). > +float angle = cos(s->angle/180.0*PI); If you want a float as result, use cosf(s->angle / 180.f * M_PI). (I'm aware PI and M_PI aren't explicitly

Re: [FFmpeg-devel] [PATCH v2] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-05-27 Thread Paul B Mahol
On 5/20/19, Romane Lafon wrote: > I have updated the patch that extends aphasemeter filter. > It allows to get metadata for out-of-phase or mono sequences of stereo > streams. > It displays start, end and duration as for silencedetect filter. > Please use M_PI, and do not invent own constants.

[FFmpeg-devel] [PATCH v2] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-05-20 Thread Romane Lafon
I have updated the patch that extends aphasemeter filter. It allows to get metadata for out-of-phase or mono sequences of stereo streams. It displays start, end and duration as for silencedetect filter. From 08daf8a0394da0d482ee09f29d7cefa14b5c5440 Mon Sep 17 00:00:00 2001 From: Romane Lafon