Re: [FFmpeg-devel] [PATCH v2] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-10 Thread Marth64
To elaborate slightly: GENPTS is working within each segment, whose start and end times I have from NAV packets On Wed, Jan 10, 2024 at 10:25 Marth64 wrote: > Thank you, Nicolas. I had tinkered with concat this way in the past as > PGCs are indeed just a bunch of segments mushed together, but I

Re: [FFmpeg-devel] [PATCH v2] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-10 Thread Marth64
Thank you, Nicolas. I had tinkered with concat this way in the past as PGCs are indeed just a bunch of segments mushed together, but I had run into issues specifically with (1) concerns about forced subtitles that pop up mid stream and (2) unable to figure out custom IO with it. Since dvdnav is

Re: [FFmpeg-devel] [PATCH v2] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-10 Thread Nicolas George
Marth64 (12024-01-10): > I will add that I still had to maintain a dependency on GENPTS for the > inner MPEG demuxer. This is because dvdnav_get_current_time() does not > provide exact stream-level PTS. However, the crashing/hanging is fixed (by > parsing NAV packets), and the output is produced

Re: [FFmpeg-devel] [PATCH v2] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-10 Thread Marth64
I will add that I still had to maintain a dependency on GENPTS for the inner MPEG demuxer. This is because dvdnav_get_current_time() does not provide exact stream-level PTS. However, the crashing/hanging is fixed (by parsing NAV packets), and the output is produced smoothly. GENPTS fills in the

[FFmpeg-devel] [PATCH v2] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-10 Thread Marth64
Dust off those old DVD discs! This version is greatly simplified and improved from the patch submitted in December. Discontinuity issues are resolved, and many discs should work smoothly out of the box. Also, GPL sector validation code is removed. Basic Usage: ffmpeg -f dvdvideo -title 1 -i