Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

On Wed, Mar 21, 2018 at 11:30 PM, Courtland Idstrom wrote: > > > Please let me know if this is sufficient. I can also upload these movies > somewhere, I didn't think it would be appropriate to attach them to this > email. > > > Cheers, > > -Courtland Thanks for the

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

On 3/21/2018 9:30 PM, Courtland Idstrom wrote: > Please let me know if this is sufficient. I can also upload these movies > somewhere, I didn't think it would be appropriate to attach them to this > email. I'm satisfied with with it, thanks for checking! Patch LGTM. - Derek

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

> > > Any way of verifying will do, even a hex editor. > > Output from Quicktime (screenshot of the movie inspector -- initial movie was created in ffmpeg, title added in quicktime, file saved: https://imgur.com/a/TPCkN) 00308ef0 00 00 00 21 75 64 74 61 00 00 00 15 6e 61 6d 65 |...!udta

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

On 3/21/2018 2:30 AM, Courtland Idstrom wrote: > What can I do to facilitate this? Would it help to create a couple of > samples from QuickTime Pro, and perhaps show the metadata atoms as > displayed by ffprobe -v trace? Any way of verifying will do, even a hex editor. - Derek

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

On Wed, Mar 21, 2018 at 4:30 AM, Courtland Idstrom wrote: > What can I do to facilitate this? Would it help to create a couple of > samples from QuickTime Pro, and perhaps show the metadata atoms as > displayed by ffprobe -v trace? > > Thanks, > -Courtland Hi, As a

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

> > > I am OK with the patch so long as it matches the behavior of how > QuickTime > > Pro (or FCP) creates files, as those are the normative references, more > > or less. > > +1 > What can I do to facilitate this? Would it help to create a couple of samples from QuickTime Pro, and perhaps show

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

On Tue, Mar 20, 2018 at 02:12:04PM +, Derek Buitenhuis wrote: > On 3/20/2018 8:31 AM, Carl Eugen Hoyos wrote: > > More precisely: I asked you if it is well-defined (assuming it is not since > > this is the only reason I can think of it was not used so far). > > He linked to the definition in

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

On 3/20/2018 8:31 AM, Carl Eugen Hoyos wrote: > More precisely: I asked you if it is well-defined (assuming it is not since > this is the only reason I can think of it was not used so far). He linked to the definition in the QTFF spec directly above, so it is certainly defined, at least. On

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

2018-03-20 5:48 GMT+01:00, Courtland Idstrom : > Any advice here? It's a requirement for my project that I set this field, > and the way it's being used for mp4 seemed exactly like what I wanted for > mov, and works perfectly. I submitted an earlier patch which

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

> > Are you sure this is correct? The links above describe '©nam' as the > title of the content, and 'name' as 'Name of Object", whatever that is > supposed to mean. > From the spec, '©nam' appears to be a localized entry, which can also be set per-track in Quicktime (exposed via their

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

On 3/19/2018 9:11 PM, Courtland Idstrom wrote: > Track title (atom 'name') is a well defined user data atom for mov files. > Existing code (for mp4) only writes title metadata if present. > > Relevant reference docs: > > >

[FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

Track title (atom 'name') is a well defined user data atom for mov files. Existing code (for mp4) only writes title metadata if present. Relevant reference docs: