Re: [FFmpeg-devel] [PATCH v2 08/11] vaapi_encode_mjpeg: Warn if input is not full range

2019-02-11 Thread Michael Niedermayer
On Sun, Feb 10, 2019 at 06:21:42PM +, Mark Thompson wrote: > On 05/02/2019 13:27, Carl Eugen Hoyos wrote: > > 2019-01-28 0:47 GMT+01:00, Mark Thompson : > > > >> +if (avctx->color_range == AVCOL_RANGE_MPEG) { > >> +av_log(avctx, AV_LOG_WARNING, "Input video does not appear " > >>

Re: [FFmpeg-devel] [PATCH v2 08/11] vaapi_encode_mjpeg: Warn if input is not full range

2019-02-10 Thread Mark Thompson
On 10/02/2019 18:49, Carl Eugen Hoyos wrote: > 2019-02-10 19:21 GMT+01:00, Mark Thompson : >> On 05/02/2019 13:27, Carl Eugen Hoyos wrote: >>> 2019-01-28 0:47 GMT+01:00, Mark Thompson : >>> +if (avctx->color_range == AVCOL_RANGE_MPEG) { +av_log(avctx, AV_LOG_WARNING, "Input

Re: [FFmpeg-devel] [PATCH v2 08/11] vaapi_encode_mjpeg: Warn if input is not full range

2019-02-10 Thread Carl Eugen Hoyos
2019-02-10 19:21 GMT+01:00, Mark Thompson : > On 05/02/2019 13:27, Carl Eugen Hoyos wrote: >> 2019-01-28 0:47 GMT+01:00, Mark Thompson : >> >>> +if (avctx->color_range == AVCOL_RANGE_MPEG) { >>> +av_log(avctx, AV_LOG_WARNING, "Input video does not appear " >>> + "to use

Re: [FFmpeg-devel] [PATCH v2 08/11] vaapi_encode_mjpeg: Warn if input is not full range

2019-02-10 Thread Mark Thompson
On 05/02/2019 13:27, Carl Eugen Hoyos wrote: > 2019-01-28 0:47 GMT+01:00, Mark Thompson : > >> +if (avctx->color_range == AVCOL_RANGE_MPEG) { >> +av_log(avctx, AV_LOG_WARNING, "Input video does not appear " >> + "to use full-range: output colours may be incorrect.\n"); >

Re: [FFmpeg-devel] [PATCH v2 08/11] vaapi_encode_mjpeg: Warn if input is not full range

2019-02-05 Thread Carl Eugen Hoyos
2019-01-28 0:47 GMT+01:00, Mark Thompson : > +if (avctx->color_range == AVCOL_RANGE_MPEG) { > +av_log(avctx, AV_LOG_WARNING, "Input video does not appear " > + "to use full-range: output colours may be incorrect.\n"); The wording seems not ideal to me: Are you not sure

[FFmpeg-devel] [PATCH v2 08/11] vaapi_encode_mjpeg: Warn if input is not full range

2019-01-27 Thread Mark Thompson
--- libavcodec/vaapi_encode_mjpeg.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/vaapi_encode_mjpeg.c b/libavcodec/vaapi_encode_mjpeg.c index 350800697f..e52f8b9820 100644 --- a/libavcodec/vaapi_encode_mjpeg.c +++ b/libavcodec/vaapi_encode_mjpeg.c @@ -460,6 +460,11 @@