Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
On Wed, Feb 17, 2021 at 11:30 AM Wonkap Jang wrote: > > > On Wed, Feb 17, 2021 at 9:50 AM Nicolas George wrote: > >> Wonkap Jang (12021-02-17): >> > While parsing ref_frame_config, AVdictionary needs to be manually >> > deallocated. >> > --- >> > libavcodec/libvpxenc.c | 21

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
On Wed, Feb 17, 2021 at 9:50 AM Nicolas George wrote: > Wonkap Jang (12021-02-17): > > While parsing ref_frame_config, AVdictionary needs to be manually > > deallocated. > > --- > > libavcodec/libvpxenc.c | 21 + > > 1 file changed, 13 insertions(+), 8 deletions(-) > > > >

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Nicolas George
Wonkap Jang (12021-02-17): > While parsing ref_frame_config, AVdictionary needs to be manually > deallocated. > --- > libavcodec/libvpxenc.c | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Nicolas George
Wonkap Jang (12021-02-17): > Or are you saying after getting the string with en->value, I should just > parse through the string without dictionary? Yes, exactly. You would use a dictionary if you need to keep all the values for a later use. But in this case, there is no later use, you only

[FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
While parsing ref_frame_config, AVdictionary needs to be manually deallocated. --- libavcodec/libvpxenc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 284cb9a108..56a1b5aafe 100644 ---

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
On Wed, Feb 17, 2021 at 8:52 AM Wonkap Jang wrote: > Hi Nicolas, > > On Wed, Feb 17, 2021 at 3:00 AM Nicolas George wrote: > >> Wonkap Jang (12021-02-16): >> > While parsing ref_frame_config, AVdictionary needs to be manually >> > deallocated. >> > --- >> > libavcodec/libvpxenc.c | 19

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
Hi Nicolas, On Wed, Feb 17, 2021 at 3:00 AM Nicolas George wrote: > Wonkap Jang (12021-02-16): > > While parsing ref_frame_config, AVdictionary needs to be manually > > deallocated. > > --- > > libavcodec/libvpxenc.c | 19 --- > > 1 file changed, 12 insertions(+), 7

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Nicolas George
Wonkap Jang (12021-02-16): > While parsing ref_frame_config, AVdictionary needs to be manually > deallocated. > --- > libavcodec/libvpxenc.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) NAK. This code is all wrong, it looks like Java or Python, it should not be

[FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread Wonkap Jang
While parsing ref_frame_config, AVdictionary needs to be manually deallocated. --- libavcodec/libvpxenc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 284cb9a108..b552590b7b 100644 ---