[FFmpeg-devel] [PATCH v3] libavcodec: implementation of DNxUncompressed decoder

2024-09-10 Thread martin schitter
On 10.09.24 01:19, Marton Balint wrote: You should split this patch to at least 3 parts for easier review. Adding the codec ID and description, adding MXF demux support, and adding the decoder/parser. O.k. -- I'll try to rearrange the changes into a structured group of patches. Right now

Re: [FFmpeg-devel] [PATCH v3] libavcodec: implementation of DNxUncompressed decoder

2024-09-10 Thread martin schitter
On 09.09.24 12:42, Anton Khirnov wrote: Quoting Martin Schitter (2024-09-08 20:41:38) I'm still unsure about my solution of adding the codec_id entries and increasing the lead-position value, as criticized by Andreas Rheinhard, but I don't see any other way to make it better. I think you're

Re: [FFmpeg-devel] [PATCH v3] libavcodec: implementation of DNxUncompressed decoder

2024-09-10 Thread martin schitter
Thanks for this careful review. On 09.09.24 12:56, Anton Khirnov wrote: Quoting Martin Schitter (2024-09-08 20:41:38) diff --git a/libavcodec/dnxucdec.c b/libavcodec/dnxucdec.c new file mode 100644 index 000..455c374 --- /dev/null +++ b/libavcodec/dnxucdec.c @@ -0,0 +1,495 @@ +/* + * Avid D

Re: [FFmpeg-devel] [PATCH v3] libavcodec: implementation of DNxUncompressed decoder

2024-09-09 Thread Marton Balint
On Sun, 8 Sep 2024, Martin Schitter wrote: As suggested by Zhao Zhili, here is a squash rebased 3rd attempt. I'm still unsure about my solution of adding the codec_id entries and increasing the lead-position value, as criticized by Andreas Rheinhard, but I don't see any other way to make it

Re: [FFmpeg-devel] [PATCH v3] libavcodec: implementation of DNxUncompressed decoder

2024-09-09 Thread Anton Khirnov
Quoting Martin Schitter (2024-09-08 20:41:38) > diff --git a/libavcodec/dnxucdec.c b/libavcodec/dnxucdec.c > new file mode 100644 > index 000..455c374 > --- /dev/null > +++ b/libavcodec/dnxucdec.c > @@ -0,0 +1,495 @@ > +/* > + * Avid DNxUncomressed / SMPTE RDD 50 demuxer This says it's a demux

Re: [FFmpeg-devel] [PATCH v3] libavcodec: implementation of DNxUncompressed decoder

2024-09-09 Thread Anton Khirnov
Quoting Martin Schitter (2024-09-08 20:41:38) > As suggested by Zhao Zhili, here is a squash rebased 3rd attempt. > > I'm still unsure about my solution of adding the codec_id entries and > increasing the lead-position value, as criticized by Andreas Rheinhard, > but I don't see any other way to m

[FFmpeg-devel] [PATCH v3] libavcodec: implementation of DNxUncompressed decoder

2024-09-08 Thread Martin Schitter
As suggested by Zhao Zhili, here is a squash rebased 3rd attempt. I'm still unsure about my solution of adding the codec_id entries and increasing the lead-position value, as criticized by Andreas Rheinhard, but I don't see any other way to make it better. martin --- Changelog |