Re: [FFmpeg-devel] [PATCH v3] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Phil Burr
I've found some fields that aren't being set correctly. I've corrected those and I'll push a new patch after I've done proper testing. Phil On Mon, May 20, 2019 at 11:03 AM Thomas Volkert wrote: > > On 20.05.2019 18:56, Phil Burr wrote: > > Besides passing `make fate` locally, I have manually

Re: [FFmpeg-devel] [PATCH v3] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Thomas Volkert
On 20.05.2019 18:56, Phil Burr wrote: > Besides passing `make fate` locally, I have manually inspected data streams > to look at my packets Okay, that is standard. > and I've used SDR software to transmit to various TV > sets I own and have verified correct virtual channel and channel name on

Re: [FFmpeg-devel] [PATCH v3] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Phil Burr
Besides passing `make fate` locally, I have manually inspected data streams to look at my packets and I've used SDR software to transmit to various TV sets I own and have verified correct virtual channel and channel name on those receivers. On Mon, May 20, 2019 at 10:44 AM Thomas Volkert wrote:

Re: [FFmpeg-devel] [PATCH v3] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Thomas Volkert
On 20.05.2019 18:09, Phillip Burr wrote: > Minimal support for ATSC PSIP tables. Does not support STT or > EIT tables and so is not compliant with terrestrial ATSC. > ATSC tables are not created by default, and will only be transmitted > if either "atsc_name" or "atsc_channel" metadata is

[FFmpeg-devel] [PATCH v3] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Phillip Burr
Minimal support for ATSC PSIP tables. Does not support STT or EIT tables and so is not compliant with terrestrial ATSC. ATSC tables are not created by default, and will only be transmitted if either "atsc_name" or "atsc_channel" metadata is supplied. Signed-off-by: Phillip Burr ---