Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mxfenc: use track count to generate component instance uuid

2017-12-07 Thread Michael Niedermayer
On Thu, Dec 07, 2017 at 10:50:37PM +0100, Tomas Härdin wrote: > On Thu, 2017-12-07 at 22:40 +0100, Michael Niedermayer wrote: > > On Thu, Dec 07, 2017 at 04:41:09PM +0100, Tomas Härdin wrote: > > > On 2017-12-05 05:46, Mark Reid wrote: > > > > @@ -1398,16 +1397,26 @@ static void > > > >

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mxfenc: use track count to generate component instance uuid

2017-12-07 Thread Tomas Härdin
On Thu, 2017-12-07 at 22:40 +0100, Michael Niedermayer wrote: > On Thu, Dec 07, 2017 at 04:41:09PM +0100, Tomas Härdin wrote: > > On 2017-12-05 05:46, Mark Reid wrote: > > > @@ -1398,16 +1397,26 @@ static void > > > mxf_write_package(AVFormatContext *s, MXFPackage *package) > > >

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mxfenc: use track count to generate component instance uuid

2017-12-07 Thread Michael Niedermayer
On Thu, Dec 07, 2017 at 04:41:09PM +0100, Tomas Härdin wrote: > On 2017-12-05 05:46, Mark Reid wrote: > >@@ -1398,16 +1397,26 @@ static void mxf_write_package(AVFormatContext *s, > >MXFPackage *package) > > mxf_write_uuid(pb, SubDescriptor, 0); > > } > >+/* > >+ * for

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mxfenc: use track count to generate component instance uuid

2017-12-07 Thread Tomas Härdin
On 2017-12-05 05:46, Mark Reid wrote: @@ -1398,16 +1397,26 @@ static void mxf_write_package(AVFormatContext *s, MXFPackage *package) mxf_write_uuid(pb, SubDescriptor, 0); } +/* + * for every 1 track in a package there is 1 sequence and 1 component. + * all 3

[FFmpeg-devel] [PATCH v3 1/3] avformat/mxfenc: use track count to generate component instance uuid

2017-12-04 Thread Mark Reid
--- libavformat/mxf.h | 1 - libavformat/mxfenc.c| 42 ++--- tests/ref/fate/copy-trac4914| 2 +- tests/ref/fate/time_base| 2 +- tests/ref/lavf/mxf | 6 +++--- tests/ref/lavf/mxf_d10 | 2 +-