Nicolas George:
> Moritz Barsnick (12020-08-28):
>> "case" indentation is too large.
>
> Thanks.
>
> Fixed, rebased and series pushed.
>
> Regards,
>
>
Seems like this patchset broke compilation with some old versions of
GCC. See
Moritz Barsnick (12020-08-28):
> "case" indentation is too large.
Thanks.
Fixed, rebased and series pushed.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
On Mon, Aug 24, 2020 at 13:36:50 +0200, Nicolas George wrote:
> +switch (link->type) {
> +
> +case AVMEDIA_TYPE_VIDEO:
> +if ((ret = ff_formats_check_pixel_formats(log, cfg->formats)) <
> 0)
> +return ret;
> +break;
> +
> +case
Andreas Rheinhardt (12020-08-24):
> >>> +if (fmts->all_layouts < fmts->all_counts ||
> >>> +(!fmts->all_layouts && !fmts->nb_channel_layouts)) {
> The above check already contains "|| (!fmts->all_layouts &&
> !fmts->nb_channel_layouts)". So if everything is zero, you get the error
>
Nicolas George:
> Andreas Rheinhardt (12020-08-24):
>> expects
>
>> switch to
>
>> preferred
>
> Locally fixed.
>
>>> +if (fmts->all_layouts < fmts->all_counts ||
>>> +(!fmts->all_layouts && !fmts->nb_channel_layouts)) {
>>
>> As has already been said in my review of the first
Andreas Rheinhardt (12020-08-24):
> expects
> switch to
> preferred
Locally fixed.
> > +if (fmts->all_layouts < fmts->all_counts ||
> > +(!fmts->all_layouts && !fmts->nb_channel_layouts)) {
>
> As has already been said in my review of the first version:
> This check doesn't fit to
Nicolas George:
> Part of the code expect valid lists, in particular no duplicates.
expects
> These tests allow to catch bugs in filters (unlikely but possible)
> and to give a clear message when the error comes from the user
> ((a)formats) or the application (buffersink).
>
> If we decide to
Part of the code expect valid lists, in particular no duplicates.
These tests allow to catch bugs in filters (unlikely but possible)
and to give a clear message when the error comes from the user
((a)formats) or the application (buffersink).
If we decide to switch for a more efficient merging
