Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-12-11 Thread Leo Izen
On 12/10/23 23:20, Kacper Michajlow wrote: On Tue, 28 Feb 2023 at 20:46, Leo Izen wrote: On 2/27/23 11:34, Leo Izen wrote: On 2/21/23 17:35, Leo Izen wrote: These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. ---

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-12-10 Thread Kacper Michajlow
On Tue, 28 Feb 2023 at 20:46, Leo Izen wrote: > > On 2/27/23 11:34, Leo Izen wrote: > > On 2/21/23 17:35, Leo Izen wrote: > >> These chunks are lightweight and it's useful information to have when > >> running ffmpeg -i or ffprobe, for example. > >> --- > >> libavcodec/pngdec.c | 136

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-28 Thread Leo Izen
On 2/27/23 11:34, Leo Izen wrote: On 2/21/23 17:35, Leo Izen wrote: These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. ---   libavcodec/pngdec.c  | 136 ++-   tests/ref/fate/png-icc   |   8

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-27 Thread Leo Izen
On 2/21/23 17:35, Leo Izen wrote: These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. --- libavcodec/pngdec.c | 136 ++- tests/ref/fate/png-icc | 8 +-- tests/ref/fate/png-side-data

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-22 Thread Ronald S. Bultje
On Wed, Feb 22, 2023 at 8:49 AM Leo Izen wrote: > On 2/21/23 20:42, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Feb 21, 2023 at 5:36 PM Leo Izen > > wrote: > > > > These chunks are lightweight and it's useful information to have when > > running ffmpeg -i

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-22 Thread Leo Izen
On 2/21/23 20:42, Ronald S. Bultje wrote: Hi, On Tue, Feb 21, 2023 at 5:36 PM Leo Izen > wrote: These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. I disagree conceptually with this. If we want

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-21 Thread Ronald S. Bultje
Hi, On Tue, Feb 21, 2023 at 5:36 PM Leo Izen wrote: > These chunks are lightweight and it's useful information to have when > running ffmpeg -i or ffprobe, for example. > I disagree conceptually with this. If we want to skip "all" decoding, we should also skip metadata for said frames. I

[FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-21 Thread Leo Izen
These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. --- libavcodec/pngdec.c | 136 ++- tests/ref/fate/png-icc | 8 +-- tests/ref/fate/png-side-data | 2 +- 3 files changed, 91