Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-27 Thread Steven Liu
> On Dec 27, 2018, at 21:30, Ronak Patel > wrote: > > > >> On Dec 17, 2018, at 9:58 AM, Steven Liu wrote: >> >> >> On Dec 17, 2018, at 21:07, Ronak Patel wrote: On Dec 13, 2018, at 9:15 PM, Ronak Patel wrote: > On Dec 12, 2018,

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-27 Thread Ronak Patel
> On Dec 17, 2018, at 9:58 AM, Steven Liu wrote: > > > >>> On Dec 17, 2018, at 21:07, Ronak Patel >>> wrote: >>> >>> >>> On Dec 13, 2018, at 9:15 PM, Ronak Patel >>> wrote: >>> >>> >>> On Dec 12, 2018, at 2:46 AM, Liu Steven wrote: >> 在

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-17 Thread Steven Liu
> On Dec 17, 2018, at 21:07, Ronak Patel > wrote: > >> >> On Dec 13, 2018, at 9:15 PM, Ronak Patel >> wrote: >> >> >> >>> On Dec 12, 2018, at 2:46 AM, Liu Steven wrote: >>> >>> >>> > 在 2018年12月12日,上午5:08,Ronak 写道: > > > On Dec 11, 2018, at 3:28 PM, Gyan wrote:

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-17 Thread Ronak Patel
> On Dec 13, 2018, at 9:15 PM, Ronak Patel > wrote: > > > >> On Dec 12, 2018, at 2:46 AM, Liu Steven wrote: >> >> >> 在 2018年12月12日,上午5:08,Ronak 写道: On Dec 11, 2018, at 3:28 PM, Gyan wrote: > On 12-12-2018 01:13 AM, Ronak wrote: > > Looks

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-13 Thread Ronak Patel
> On Dec 12, 2018, at 2:46 AM, Liu Steven wrote: > > > >>> 在 2018年12月12日,上午5:08,Ronak 写道: >>> >>> >>> On Dec 11, 2018, at 3:28 PM, Gyan wrote: >>> >>> On 12-12-2018 01:13 AM, Ronak wrote: Looks like I found out why:

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-11 Thread Liu Steven
> 在 2018年12月12日,上午5:08,Ronak 写道: > >> >> On Dec 11, 2018, at 3:28 PM, Gyan wrote: >> >> >> On 12-12-2018 01:13 AM, Ronak wrote: >>> >>> Looks like I found out why: >>> https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/hlsenc.c#L790. The >>> hlsenc.c file overwrites whatever I

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-11 Thread Ronak
> On Dec 11, 2018, at 3:28 PM, Gyan wrote: > > > On 12-12-2018 01:13 AM, Ronak wrote: >> >> Looks like I found out why: >> https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/hlsenc.c#L790. The >> hlsenc.c file overwrites whatever I pass in the command line... > > That is a bug but

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-11 Thread Gyan
On 12-12-2018 01:13 AM, Ronak wrote: Looks like I found out why: https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/hlsenc.c#L790. The hlsenc.c file overwrites whatever I pass in the command line... That is a bug but there's still an error in your command. It should be,    

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-11 Thread Ronak
> On Dec 11, 2018, at 1:42 PM, Ronak wrote: > > > >> On Dec 11, 2018, at 12:35 AM, Jeyapal, Karthick wrote: >> >> >> >> On 12/11/18, 9:07 AM, "Ronak" wrote: >> >>> On Dec 6, 2018, at 4:47 AM, Tobias Rapp wrote: On 06.12.2018 08:28, Karthick J wrote: > --- >

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-11 Thread Ronak
> On Dec 11, 2018, at 12:35 AM, Jeyapal, Karthick wrote: > > > > On 12/11/18, 9:07 AM, "Ronak" wrote: > >> >>> On Dec 6, 2018, at 4:47 AM, Tobias Rapp wrote: >>> >>> On 06.12.2018 08:28, Karthick J wrote: --- [...] >>> >>> Looks OK now, no more comments from my side. >> >>

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-10 Thread Jeyapal, Karthick
On 12/11/18, 9:07 AM, "Ronak" wrote: > >> On Dec 6, 2018, at 4:47 AM, Tobias Rapp wrote: >> >> On 06.12.2018 08:28, Karthick J wrote: >>> --- >>> [...] >> >> Looks OK now, no more comments from my side. > >I actually was going to submit a patch that would remove sidx atoms being >written

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-10 Thread Jeyapal, Karthick
On 12/6/18, 3:18 PM, "Tobias Rapp" wrote: > >On 06.12.2018 08:28, Karthick J wrote: >> --- >> doc/muxers.texi | 4 >> libavformat/movenc.c | 12 ++-- >> libavformat/movenc.h | 1 + >> 3 files changed, 15 insertions(+), 2 deletions(-) >> >> [...] > >Looks OK now, no

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-10 Thread Ronak
> On Dec 6, 2018, at 4:47 AM, Tobias Rapp wrote: > > On 06.12.2018 08:28, Karthick J wrote: >> --- >> doc/muxers.texi | 4 >> libavformat/movenc.c | 12 ++-- >> libavformat/movenc.h | 1 + >> 3 files changed, 15 insertions(+), 2 deletions(-) >> [...] > > Looks OK now, no

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-06 Thread Tobias Rapp
On 06.12.2018 08:28, Karthick J wrote: --- doc/muxers.texi | 4 libavformat/movenc.c | 12 ++-- libavformat/movenc.h | 1 + 3 files changed, 15 insertions(+), 2 deletions(-) [...] Looks OK now, no more comments from my side. Regards, Tobias

[FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-05 Thread Karthick J
--- doc/muxers.texi | 4 libavformat/movenc.c | 12 ++-- libavformat/movenc.h | 1 + 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index f1cc6f5fee..ca10741900 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1325,6