Re: [FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

2020-05-23 Thread Limin Wang
On Sat, May 23, 2020 at 04:52:47PM +0200, Nicolas George wrote: > Limin Wang (12020-05-23): > > > In this case, transforming the string into an AVDictionary, passing it > > > around and warning if there are remaining options should be the simplest > > > choice. > > > > So I should to use

Re: [FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

2020-05-23 Thread Nicolas George
Limin Wang (12020-05-23): > > In this case, transforming the string into an AVDictionary, passing it > > around and warning if there are remaining options should be the simplest > > choice. > > So I should to use av_find_info_tag to parse the options string? any sample > code > in the existing

Re: [FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

2020-05-23 Thread Limin Wang
On Sat, May 23, 2020 at 04:36:24PM +0200, Nicolas George wrote: > Limin Wang (12020-05-23): > > OK, if nobody object it, I'll remove it after the patchset are OK. > > That should be in the same patch. > > > I have no idea how to use parse_key_value_pair() and how to support it in > > command >

Re: [FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

2020-05-23 Thread Nicolas George
Limin Wang (12020-05-23): > OK, if nobody object it, I'll remove it after the patchset are OK. That should be in the same patch. > I have no idea how to use parse_key_value_pair() and how to support it in > command > line with option? so I use it as format directly. The answer to something we

Re: [FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

2020-05-23 Thread Limin Wang
On Sat, May 23, 2020 at 02:41:01PM +0200, Mattias Wadman wrote: > On Sat, May 23, 2020 at 2:23 AM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/ffmpeg.texi | 15 > > fftools/ffmpeg.h| 2 ++ > > fftools/ffmpeg_filter.c | 20

Re: [FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

2020-05-23 Thread Limin Wang
On Sat, May 23, 2020 at 02:49:39PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-05-23): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/ffmpeg.texi | 15 > > > fftools/ffmpeg.h| 2 ++ > > fftools/ffmpeg_filter.c | 20

Re: [FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

2020-05-23 Thread Nicolas George
lance.lmw...@gmail.com (12020-05-23): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/ffmpeg.texi | 15 > fftools/ffmpeg.h| 2 ++ > fftools/ffmpeg_filter.c | 20 > fftools/ffmpeg_opt.c| 20 >

Re: [FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

2020-05-23 Thread Mattias Wadman
On Sat, May 23, 2020 at 2:23 AM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/ffmpeg.texi | 15 > fftools/ffmpeg.h| 2 ++ > fftools/ffmpeg_filter.c | 20 > fftools/ffmpeg_opt.c| 20 >

[FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

2020-05-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/ffmpeg.texi | 15 fftools/ffmpeg.h| 2 ++ fftools/ffmpeg_filter.c | 20 fftools/ffmpeg_opt.c| 20 libavfilter/graphdump.c | 63