Re: [FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Moritz Barsnick
On Tue, Apr 09, 2019 at 20:45:41 +0530, Shivam Goyal wrote: > > I believe Carl Eugen asked you to change this to: > > AVPROBE_SCORE_EXTENSION / 2 + 1 > Carl Eugen suggested me to change to AVPROBE_SCORE_MAX /2 +1 Ah, sorry, my bad - I missed that. Thanks, Moritz

Re: [FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Shivam Goyal
On 09-04-2019 08:32 PM, Moritz Barsnick wrote: Some minor nitpicking remarks from me: Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720. Basically, the second sentence belongs into the body of the commit message, after a single empty line separator. (It may not

Re: [FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Moritz Barsnick
Some minor nitpicking remarks from me: > Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720. Basically, the second sentence belongs into the body of the commit message, after a single empty line separator. (It may not matter here.) > Changelog| 1 + >

Re: [FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Carl Eugen Hoyos
2019-04-09 16:19 GMT+02:00, Shivam Goyal : > lavf/flv: Add XV (Xunlei Video) Support. > > Fixes ticket #3720 > > I have fixed the minor mistakes in the patch. I have also > checked the patch with patcheck. > +offset = ((avio_r8(ic) + rot & 0xff) << 24 | > +(avio_r8(ic) + rot &

[FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Shivam Goyal
lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720 I have fixed the minor mistakes in the patch. I have also checked the patch with patcheck. >From a64698a11c10ec62968a5d853d7db0fed956c0d3 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Tue, 9 Apr 2019 19:25:23 +0530 Subject: