Re: [FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

2016-08-18 Thread Marton Balint
On Thu, 18 Aug 2016, Nicolas George wrote: Le decadi 30 thermidor, an CCXXIV, Marton Balint a écrit : I remember some other advantages of flushing in blocks as well, which made me suggest it to Jan: - It is a good thing if the consumer knows that there was a packet discontinuity, it can

Re: [FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

2016-08-18 Thread Nicolas George
Le decadi 30 thermidor, an CCXXIV, Jan Sebechlebsky a écrit : > I am not sure if I understand this. Do you mean thread queue function which > would set > certain flag that the queue should be flushed and flushed the queue at > certain point in time (next receive call?)? That is a bit too specific

Re: [FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

2016-08-18 Thread Nicolas George
Le decadi 30 thermidor, an CCXXIV, Marton Balint a écrit : > I remember some other advantages of flushing in blocks as well, which made > me suggest it to Jan: > > - It is a good thing if the consumer knows that there was a packet > discontinuity, it can decide what to do. If you drop packets

Re: [FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

2016-08-15 Thread Jan Sebechlebsky
On 08/16/2016 01:05 AM, Jan Sebechlebsky wrote: On 08/15/2016 11:50 PM, Nicolas George wrote: + +if (just_flushed) +av_log(avf, AV_LOG_INFO, "FIFO queue flushed\n"); + +ret = av_thread_message_queue_recv(queue, , 0); [...] +if (ret < 0) { +

Re: [FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

2016-08-15 Thread Marton Balint
+if (!fifo->overflow_flag) +fifo->overflow_flag = overflow_set = 1; +pthread_mutex_unlock(>overflow_flag_lock); + +if (overflow_set) +av_log(avf, AV_LOG_WARNING, "FIFO queue full\n"); +ret = 0; +goto fail; Can you explain why

Re: [FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

2016-08-15 Thread Jan Sebechlebsky
On 08/15/2016 11:50 PM, Nicolas George wrote: L'octidi 28 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : [...] +s@item recovery_wait_streamtime @var{bool} ^ Strange. Sorry, that is obviously a typo. Strange thing is it had not produced any kind of warning/error. [...]

Re: [FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

2016-08-15 Thread Nicolas George
L'octidi 28 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : > From: Jan Sebechlebsky > > Signed-off-by: Jan Sebechlebsky > --- > Changes since the last version of the patch: > - Fixed documentation (apart from the Marton's

[FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

2016-08-14 Thread sebechlebskyjan
From: Jan Sebechlebsky Signed-off-by: Jan Sebechlebsky --- Changes since the last version of the patch: - Fixed documentation (apart from the Marton's suggestions I've also changed example, since it used block_on_overflow option from