Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-05-07 Thread Michael Niedermayer
On Tue, May 05, 2015 at 09:16:44PM +0200, Andreas Cadhalpun wrote: > On 23.04.2015 17:50, Claudio Freire wrote: > > On Thu, Apr 23, 2015 at 12:43 PM, Michael Niedermayer > > wrote: > >> ok, so is the patch the correct solution or are the fields already > >> invalid before this loop and should hav

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-05-05 Thread Andreas Cadhalpun
On 23.04.2015 17:50, Claudio Freire wrote: > On Thu, Apr 23, 2015 at 12:43 PM, Michael Niedermayer > wrote: >> ok, so is the patch the correct solution or are the fields already >> invalid before this loop and should have been checked prior ? > > I think either the fields are already invalid bef

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-23 Thread Claudio Freire
On Thu, Apr 23, 2015 at 12:43 PM, Michael Niedermayer wrote: > On Thu, Apr 23, 2015 at 12:22:49PM -0300, Claudio Freire wrote: >> On Wed, Apr 22, 2015 at 1:52 PM, Vittorio Giovara >> wrote: >> I don't think the INVALIDDATA return will have the desired effect. >> >> I think you want

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-23 Thread Michael Niedermayer
On Thu, Apr 23, 2015 at 12:22:49PM -0300, Claudio Freire wrote: > On Wed, Apr 22, 2015 at 1:52 PM, Vittorio Giovara > wrote: > I don't think the INVALIDDATA return will have the desired effect. > > I think you want return -1; > >>> > >>> This function is only called once and there t

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-23 Thread Claudio Freire
On Wed, Apr 22, 2015 at 1:52 PM, Vittorio Giovara wrote: I don't think the INVALIDDATA return will have the desired effect. I think you want return -1; >>> >>> This function is only called once and there the check is: >>> if (sbr_hf_calc_npatches(ac, sbr) < 0) >>> return

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-22 Thread Vittorio Giovara
On Wed, Apr 22, 2015 at 5:31 PM, Claudio Freire wrote: > On Wed, Apr 22, 2015 at 12:54 PM, Andreas Cadhalpun > wrote: >> On 22.04.2015 17:35, Claudio Freire wrote: >>> On Wed, Apr 22, 2015 at 10:23 AM, Andreas Cadhalpun >>> wrote: +if (k == last_k && msb == last_msb) { +

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-22 Thread Andreas Cadhalpun
On 22.04.2015 18:52, Vittorio Giovara wrote: > On Wed, Apr 22, 2015 at 5:31 PM, Claudio Freire > wrote: >> On Wed, Apr 22, 2015 at 12:54 PM, Andreas Cadhalpun >> wrote: >>> On 22.04.2015 17:35, Claudio Freire wrote: On Wed, Apr 22, 2015 at 10:23 AM, Andreas Cadhalpun wrote: > +

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-22 Thread Andreas Cadhalpun
On 22.04.2015 18:31, Claudio Freire wrote: > On Wed, Apr 22, 2015 at 12:54 PM, Andreas Cadhalpun > wrote: >> On 22.04.2015 17:35, Claudio Freire wrote: >>> On Wed, Apr 22, 2015 at 10:23 AM, Andreas Cadhalpun >>> wrote: +if (k == last_k && msb == last_msb) { +av_log(a