>
> LGTM
>
> thanks
>
> [...]
> --
> Michael
>
Pushed, thanks.
Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hi
On Sun, Dec 02, 2018 at 09:44:38PM +0100, Martin Vignali wrote:
> internal.h | 12
> utils.c| 19 +++
> 2 files changed, 31 insertions(+)
> 46843c218e2c53b93a283656dc3e89f93775a286
> 0001-avcodec-utils-add-ff_int_from_list_or_default-func.patch
> From
Hello,
No strong opinion about the func name, so change to
ff_int_from_list_or_default
Change int array to const int (in func and in prores_aw)
Martin
0003-avcodec-prores_aw-only-set-color-prim-trc-space.patch
Description: Binary data
On Sun, Dec 02, 2018 at 01:52:49PM +0100, Martin Vignali wrote:
> Hello,
>
> New patch in attach
>
> 001 : add ff_int_is_in_list func to libavcodec/utils.c
> 002 : add vendor option (unchanged)
> 003 : only write color properties if supported (use new ff_int_is_in_list
> func)
> 004 : Add 444Xq
Hello,
New patch in attach
001 : add ff_int_is_in_list func to libavcodec/utils.c
002 : add vendor option (unchanged)
003 : only write color properties if supported (use new ff_int_is_in_list
func)
004 : Add 444Xq (unchanged)
Martin
0003-avcodec-prores_aw-only-set-color-prim-trc-space.patch
On Mon, Nov 26, 2018 at 04:19:20PM +0100, Martin Vignali wrote:
> > > +
> > > +switch (pict->colorspace) {
> > > +case AVCOL_SPC_BT709:
> > > +case AVCOL_SPC_UNSPECIFIED:
> > > +case AVCOL_SPC_SMPTE170M:
> > > +case AVCOL_SPC_BT2020_NCL:
> > > +colorspace =
> > (alpha 12b encoding is probably
> > easy to add)
>
> Are you sure alpha is 12 bit? As long as I remember, it is 16 bit.
>
>
Alpha is stored in 16b, but like the input pix fmt is 10b or (later) 12b
alpha, the alpha val is shift during encoding to obtain a 16b val.
The right way will be to add
> On 26 Nov 2018, at 15:28, Martin Vignali wrote:
>
> (alpha 12b encoding is probably
> easy to add)
Are you sure alpha is 12 bit? As long as I remember, it is 16 bit.
Best regards, Reto
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
>
> So I applied these patches and it appears that ffmpeg will encode XQ as
> 10-bit, but it will decode as 12-bit. Is this intentional? I worry that I
> might have applied the patches incorrectly. And is it possible to add
> 12-bit encoding?
>
>
Hello,
Seems like you applied patch "add 12b
> > +
> > +switch (pict->colorspace) {
> > +case AVCOL_SPC_BT709:
> > +case AVCOL_SPC_UNSPECIFIED:
> > +case AVCOL_SPC_SMPTE170M:
> > +case AVCOL_SPC_BT2020_NCL:
> > +colorspace = pict->colorspace;
> > +break;
> > +default:
> > +av_log(avctx,
On Mon, Nov 26, 2018 at 8:06 AM Kieran O Leary
wrote:
>
>
> On Sat, 24 Nov 2018, 22:11 Martin Vignali
>> Hello,
>>
>> Patch in attach add some improvments to prores aw encoder
>>
>> 012 : Add vendor option (code come from prores_ks encoder)
>> 013 : Only write color properties, if defined in
On Sat, 24 Nov 2018, 22:11 Martin Vignali Hello,
>
> Patch in attach add some improvments to prores aw encoder
>
> 012 : Add vendor option (code come from prores_ks encoder)
> 013 : Only write color properties, if defined in rdd36 (other values are
> "converted" to unspecified)
> 014 : Add
On Sat, Nov 24, 2018 at 11:04:38PM +0100, Martin Vignali wrote:
> proresenc_anatoliy.c | 49 ++---
> 1 file changed, 46 insertions(+), 3 deletions(-)
> 44fe346a2be4d3d3ce2c903daf9cd599437627cc
>
Hello,
Patch in attach add some improvments to prores aw encoder
012 : Add vendor option (code come from prores_ks encoder)
013 : Only write color properties, if defined in rdd36 (other values are
"converted" to unspecified)
014 : Add XQ encoding support
Martin
14 matches
Mail list logo
