Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-12-02 Thread Martin Vignali
Pushed, thanks. Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-28 Thread Michael Niedermayer
On Tue, Nov 27, 2018 at 11:03:50PM +0100, Martin Vignali wrote: > utils.c |4 > 1 file changed, 4 insertions(+) > 16e7e76e9bde70f7604c3df1a5ec42828e38555b > 0001-avcodec-utils-add-YUVA444P12-and-YUVA422P12-to-pixfm.patch > From db7fb1bd052ff3dba0fe3510912214aa6e66d56b Mon Sep 17

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-27 Thread Martin Vignali
Hello, New patchs in attach 001 : add YUVA444P12 and YUVA422P12 to avcodec_dimensions2 (in order to have height padding) 002 to 009 : unchanged 010 : mention ticket 7163 in commit msg (unchanged otherwise) Martin 0002-avcodec-proresdsp-remove-unused-value.patch Description: Binary data

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-26 Thread Martin Vignali
> > +/* align height to 16, to avoid segfault */ > > +tframe.f->height = FFALIGN(avctx->height, 16); > > +tframe.f->width = FFALIGN(avctx->width, 16); > > +tframe.f->crop_bottom = tframe.f->height - avctx->height; > > + > > if ((ret = ff_thread_get_buffer(avctx, , 0)) < 0) > >

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-25 Thread Michael Niedermayer
On Sat, Nov 24, 2018 at 08:59:50PM +0100, Martin Vignali wrote: > proresdec2.c |5 + > 1 file changed, 5 insertions(+) > 99ab52ec787a2de79da37daa0e17c7885fcb558f > 0010-avcodec-proresdec-align-height-buffer-to-16-avoid-se.patch > From 3c319ed4ef51e25bccfa0b4fc50edf0bcebf2f0a Mon Sep 17

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-24 Thread Reto Kromer
Martin Vignali wrote: >Only enable 12b decoding if the codec tag is Prores or XQ >let 10b decoding for 422 codecs tag. Indeed! Best regards, Reto ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-24 Thread Martin Vignali
Hello, New patchs in attach (002 to 010 unchanged) 011 : Remove user option for setting decoding precision Only enable 12b decoding if the codec tag is Prores or XQ let 10b decoding for 422 codecs tag. Martin 0006-avcodec-proresdec-put-unpack-alpha-func-in-prores-ct.patch Description:

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Carl Eugen Hoyos
2018-11-18 23:50 GMT+01:00, Kieran O Leary : > On Sun, 18 Nov 2018, 21:58 Martin Vignali >> I don't know, how to get the "wanted" pix_fmt output using ffmpeg cli, >> and I don't know, what the general "rules" of this project for multiple >> pix_fmt output for the same input file. >> >> If user

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Carl Eugen Hoyos
2018-11-18 22:58 GMT+01:00, Martin Vignali : > Le dim. 18 nov. 2018 à 01:57, Carl Eugen Hoyos a > écrit : > >> 2018-11-18 0:28 GMT+01:00, Martin Vignali : >> >> > 012 : Add 12b support for 444 by default, >> >> Is it slower? >> I believe that once 12 bit decoding is not slower, it should >> be

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Kieran O Leary
On Sun, 18 Nov 2018, 21:58 Martin Vignali > I don't know, how to get the "wanted" pix_fmt output using ffmpeg cli, and > I don't know, what the general "rules" of this project for multiple pix_fmt > output for the same input file. > > If user option for decoding precision need to be remove, > i

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Martin Vignali
Le dim. 18 nov. 2018 à 01:57, Carl Eugen Hoyos a écrit : > 2018-11-18 0:28 GMT+01:00, Martin Vignali : > > > 012 : Add 12b support for 444 by default, > > Is it slower? > I believe that once 12 bit decoding is not slower, it should > be the default for 422. > Yes 12b is much slower On a 422 HQ

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Martin Vignali
> > Are all 444(4?) Encodings 12-bit? Also is there a way to verify if your > file should be decoded as 10 or 12-bit? Or does this code automate this > detection? > > The auto mode of the patch, only use codec_tag to switch between 10b and 12b, no other value. I don't think, prores have metadata

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-17 Thread Carl Eugen Hoyos
2018-11-18 0:28 GMT+01:00, Martin Vignali : > 012 : Add 12b support for 444 by default, Is it slower? I believe that once 12 bit decoding is not slower, it should be the default for 422. > and add user option for setting decoding precision I wonder if this is necessary and correct: Calling

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-17 Thread Kieran O Leary
Hi On Sat, 17 Nov 2018, 23:28 Martin Vignali Hello, > > Patchs in attach add 12b decoding for prores > Theses patch are based on patch by Kieran Kunhya > https://pastebin.com/mYNJkdMH > > After theses patch by default Prores 422 are decode in 10b and 444 in 12b > I add a user option, to force

[FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-17 Thread Martin Vignali
Hello, Patchs in attach add 12b decoding for prores Theses patch are based on patch by Kieran Kunhya https://pastebin.com/mYNJkdMH After theses patch by default Prores 422 are decode in 10b and 444 in 12b I add a user option, to force 10b or 12b decoding Need to be apply after patch "avutil -