Re: [FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-18 Thread Martin Vignali
> If you pre-multiplty the alpha and then save it as a file, how it is > supposed to know that you did that? :) > > > This is a common trouble in post-production, like some software output by default in premult and some in straight. For Mov file, Adobe set an UDTA for alpha. Never see another way

Re: [FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-18 Thread Paul B Mahol
On 3/18/18, Hendrik Leppkes wrote: > On Sun, Mar 18, 2018 at 9:26 AM, wm4 wrote: >> On Sat, 17 Mar 2018 20:46:50 +0100 >> Martin Vignali wrote: >> >>> Hello, >>> >>> Patch in attach change premultiply/unpremultiply filter for RGB input >>> to process it at full range >>> >>> Avoid very strange r

Re: [FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-18 Thread Hendrik Leppkes
On Sun, Mar 18, 2018 at 9:26 AM, wm4 wrote: > On Sat, 17 Mar 2018 20:46:50 +0100 > Martin Vignali wrote: > >> Hello, >> >> Patch in attach change premultiply/unpremultiply filter for RGB input >> to process it at full range >> >> Avoid very strange result in unpremultiply mode >> >> To test : >>

Re: [FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-18 Thread wm4
On Sat, 17 Mar 2018 20:46:50 +0100 Martin Vignali wrote: > Hello, > > Patch in attach change premultiply/unpremultiply filter for RGB input > to process it at full range > > Avoid very strange result in unpremultiply mode > > To test : > ./ffmpeg -i ./fate-suite/mov/mov_alpha_premult.mov -vf >

Re: [FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-17 Thread Paul B Mahol
On 3/17/18, Martin Vignali wrote: >> >> Obviously for whatever reason files are tagged as limited, when in fact >> they are full range. >> >> I couldn't find source of this bug. But your patch is wrong, as it >> ignores >> color_range if it is set to limited, even if such files are useless. >> > >

Re: [FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-17 Thread Martin Vignali
> > Obviously for whatever reason files are tagged as limited, when in fact > they are full range. > > I couldn't find source of this bug. But your patch is wrong, as it ignores > color_range if it is set to limited, even if such files are useless. > I think there is two problem here 1 - Frame ta

Re: [FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-17 Thread Paul B Mahol
On 3/17/18, Martin Vignali wrote: >> >> Those checks are there for the reason, fix your samples. >> > > Same wrong output if i convert the sample to png, and run unpremultiply > filter. Two wrongs does not make something bad suddenly good. Obviously for whatever reason files are tagged as limite

Re: [FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-17 Thread Martin Vignali
> > Those checks are there for the reason, fix your samples. > Same wrong output if i convert the sample to png, and run unpremultiply filter. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-17 Thread Paul B Mahol
On 3/17/18, Martin Vignali wrote: > Hello, > > Patch in attach change premultiply/unpremultiply filter for RGB input > to process it at full range > > Avoid very strange result in unpremultiply mode > > To test : > ./ffmpeg -i ./fate-suite/mov/mov_alpha_premult.mov -vf > unpremultiply=inplace=1 re

[FFmpeg-devel] avfilter/vf_premultiply : use full range for RGB input

2018-03-17 Thread Martin Vignali
Hello, Patch in attach change premultiply/unpremultiply filter for RGB input to process it at full range Avoid very strange result in unpremultiply mode To test : ./ffmpeg -i ./fate-suite/mov/mov_alpha_premult.mov -vf unpremultiply=inplace=1 resStraight.png -y ./ffmpeg -i ./fate-suite/mov/mov_a