Re: [FFmpeg-devel] avfilter/x86/vf_interlace : fix crash if unaligned data (ticket 6491)

2017-12-15 Thread Martin Vignali
> > Would it be faster to instead process the unaligned pixels > separately and use aligned access for most of the line? > > > Probably. but the asm code will become more complex. Without a checkasm test for these funcs, i prefer to not try to

Re: [FFmpeg-devel] avfilter/x86/vf_interlace : fix crash if unaligned data (ticket 6491)

2017-12-15 Thread Carl Eugen Hoyos
2017-12-14 17:01 GMT+01:00 Martin Vignali : > in attach patch to fix crash using this command line > ./ffmpeg -f lavfi -i testsrc=s=hd1080,format=yuv420p -vf > crop=1440:1080,interlace -f null - > (ticket 6491) Thank you! > Use unaligned load, to avoid crash Would it

Re: [FFmpeg-devel] avfilter/x86/vf_interlace : fix crash if unaligned data (ticket 6491)

2017-12-15 Thread Martin Vignali
> Patch LGTM, thanks! > > Regards, > Thomas > > Pushed thanks Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avfilter/x86/vf_interlace : fix crash if unaligned data (ticket 6491)

2017-12-14 Thread Thomas Mundt
2017-12-14 21:33 GMT+01:00 Thomas Mundt : > Hi, > > 2017-12-14 17:01 GMT+01:00 Martin Vignali : > >> Hello, >> >> >> in attach patch to fix crash using this command line >> ./ffmpeg -f lavfi -i testsrc=s=hd1080,format=yuv420p -vf >>

Re: [FFmpeg-devel] avfilter/x86/vf_interlace : fix crash if unaligned data (ticket 6491)

2017-12-14 Thread Martin Vignali
2017-12-14 21:33 GMT+01:00 Thomas Mundt : > Hi, > > 2017-12-14 17:01 GMT+01:00 Martin Vignali : > > > Hello, > > > > > > in attach patch to fix crash using this command line > > ./ffmpeg -f lavfi -i testsrc=s=hd1080,format=yuv420p -vf > >

Re: [FFmpeg-devel] avfilter/x86/vf_interlace : fix crash if unaligned data (ticket 6491)

2017-12-14 Thread Thomas Mundt
Hi, 2017-12-14 17:01 GMT+01:00 Martin Vignali : > Hello, > > > in attach patch to fix crash using this command line > ./ffmpeg -f lavfi -i testsrc=s=hd1080,format=yuv420p -vf > crop=1440:1080,interlace -f null - > (ticket 6491) > > Use unaligned load, to avoid crash >

[FFmpeg-devel] avfilter/x86/vf_interlace : fix crash if unaligned data (ticket 6491)

2017-12-14 Thread Martin Vignali
Hello, in attach patch to fix crash using this command line ./ffmpeg -f lavfi -i testsrc=s=hd1080,format=yuv420p -vf crop=1440:1080,interlace -f null - (ticket 6491) Use unaligned load, to avoid crash Doesn't fix crash when using low_pass_complex : ./ffmpeg -f lavfi -i