> > Patch in attach fix description, and two mistakes (not setting color
> > primaries, trc, space to auto for setfield and setrange, and colorspace
> > option for setparams
> > Sorry.
> >
> > Martin
> >
>
> LGTM
>
Pushed, thanks
Martin
___
ffmpeg-devel
On 10/21/18, Martin Vignali wrote:
>>
>> You forgot to update setparams filter long description.
>>
>>
> Patch in attach fix description, and two mistakes (not setting color
> primaries, trc, space to auto for setfield and setrange, and colorspace
> option for setparams
> Sorry.
>
> Martin
>
LGTM
>
> You forgot to update setparams filter long description.
>
>
Patch in attach fix description, and two mistakes (not setting color
primaries, trc, space to auto for setfield and setrange, and colorspace
option for setparams
Sorry.
Martin
0002-avfilter-setparams-update-filter-description.patch
On 10/21/18, Martin Vignali wrote:
>> > New patch in attach.
>> > Also add changelog entry, and libavfilter version change
>>
>> LGTM
>>
>>
> Pushed, thanks.
You forgot to update setparams filter long description.
___
ffmpeg-devel mailing list
ffmpeg-de
> > New patch in attach.
> > Also add changelog entry, and libavfilter version change
>
> LGTM
>
>
Pushed, thanks.
Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 10/21/18, Martin Vignali wrote:
>>
>> please align these vertically, it makes them easier to read
>>
>>
> New patch in attach.
> Also add changelog entry, and libavfilter version change
LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http:
>
> please align these vertically, it makes them easier to read
>
>
New patch in attach.
Also add changelog entry, and libavfilter version change
Martin
0005-avfilter-setparam-add-options-to-set-color-primaries.patch
Description: Binary data
0004-avfilter-setparams-merge-setfield-and-setrange-
On Sat, Oct 20, 2018 at 09:12:21PM +0200, Martin Vignali wrote:
[...]
> @section showinfo
> diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c
> index 5426d88777..05ccc38c0d 100644
> --- a/libavfilter/vf_setparams.c
> +++ b/libavfilter/vf_setparams.c
> @@ -35,6 +35,9 @@ typedef s
Le sam. 20 oct. 2018 à 18:18, Paul B Mahol a écrit :
> On 10/20/18, Martin Vignali wrote:
> > Hello,
> >
> >>
> >> > Blocking this patch, no code should remove old filters.
> >> >
> >>
> > I suppose you talk about the proposal of removing setfield, setrange
> later ?
>
> It was not clear from co
On 10/20/18, Martin Vignali wrote:
> Hello,
>
>>
>> > Blocking this patch, no code should remove old filters.
>> >
>>
> I suppose you talk about the proposal of removing setfield, setrange later ?
It was not clear from commit log. So patches are fine for merge.
Just missing documentation for new
Hello,
>
> > Blocking this patch, no code should remove old filters.
> >
>
I suppose you talk about the proposal of removing setfield, setrange later ?
> > If you want more parameters to be changed write new filters instead.
> >
>
This is what the current patch do.
>
> Feel free to merge code
On 10/20/18, Martin Vignali wrote:
> Hello,
>
> Missing doc update, and changelog entry.
>
> 001 : Merge setfield and setrange to a new setparams filter
> like both filter have near identical code, and merging it, can let a user
> to set all property at the same time.
>
> in setparams, the field m
On 10/20/18, Paul B Mahol wrote:
> On 10/20/18, Martin Vignali wrote:
>> Hello,
>>
>> Missing doc update, and changelog entry.
>>
>> 001 : Merge setfield and setrange to a new setparams filter
>> like both filter have near identical code, and merging it, can let a user
>> to set all property at t
Hello,
Missing doc update, and changelog entry.
001 : Merge setfield and setrange to a new setparams filter
like both filter have near identical code, and merging it, can let a user
to set all property at the same time.
in setparams, the field mode option have been rename to field_mode
Current b
14 matches
Mail list logo
