Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 6:41 GMT+01:00 Umair Khan : > Hi, > > On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >> 2017-11-12 20:30 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Am 16.11.17 um 19:24 schrieb Thilo Borgmann: > Am 14.11.17 um 08:23 schrieb Umair Khan: >> Hi, >> >> On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos wrote: >>> 2017-11-13 6:41 GMT+01:00 Umair Khan : Hi, On Mon, Nov 13, 2017 at 1:09 AM, Carl

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Am 14.11.17 um 08:23 schrieb Umair Khan: > Hi, > > On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos wrote: >> 2017-11-13 6:41 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos >>> wrote:

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-15 8:54 GMT+01:00 Umair Khan : > I'm now moving to the ALS encoder tasks before we start with the next GSoC. Great! Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, On Wed, Nov 15, 2017 at 4:20 AM, Carl Eugen Hoyos wrote: > 2017-11-14 23:48 GMT+01:00 Carl Eugen Hoyos : >> 2017-11-13 21:07 GMT+01:00 Thilo Borgmann : >>> Am 13.11.17 um 21:06 schrieb Thilo Borgmann: Am 13.11.17 um 20:02

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-14 23:48 GMT+01:00 Carl Eugen Hoyos : > 2017-11-13 21:07 GMT+01:00 Thilo Borgmann : >> Am 13.11.17 um 21:06 schrieb Thilo Borgmann: >>> Am 13.11.17 um 20:02 schrieb Umair Khan: Hi, On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 21:07 GMT+01:00 Thilo Borgmann : > Am 13.11.17 um 21:06 schrieb Thilo Borgmann: >> Am 13.11.17 um 20:02 schrieb Umair Khan: >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann >>> wrote: Hi, > On Mon, Nov 13,

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos wrote: > 2017-11-13 6:41 GMT+01:00 Umair Khan : >> Hi, >> >> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >>> 2017-11-12 20:30 GMT+01:00 Umair Khan :

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 6:41 GMT+01:00 Umair Khan : > Hi, > > On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >> 2017-11-12 20:30 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Am 13.11.17 um 21:06 schrieb Thilo Borgmann: > Am 13.11.17 um 20:02 schrieb Umair Khan: >> Hi, >> >> On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann >> wrote: >>> Hi, >>> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Am 13.11.17 um 20:02 schrieb Umair Khan: > Hi, > > On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann > wrote: >> Hi, >> >>> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos >>> wrote: 2017-11-12 20:30 GMT+01:00 Umair Khan :

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann wrote: > Hi, > >> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >>> 2017-11-12 20:30 GMT+01:00 Umair Khan : Hi, On Mon, Nov 13, 2017 at 12:45 AM, Carl

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, > On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >> 2017-11-12 20:30 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos >>> wrote: 2017-11-12 20:05 GMT+01:00 Umair Khan

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: > 2017-11-12 20:30 GMT+01:00 Umair Khan : >> Hi, >> >> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos >> wrote: >>> 2017-11-12 20:05 GMT+01:00 Umair Khan

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 20:30 GMT+01:00 Umair Khan : > Hi, > > On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos wrote: >> 2017-11-12 20:05 GMT+01:00 Umair Khan : >> >>> The attached patch fixes the address sanitizer issue. >> >> Breaks compilation

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos wrote: > 2017-11-12 20:05 GMT+01:00 Umair Khan : > >> The attached patch fixes the address sanitizer issue. > > Breaks compilation here, how did you test? > > libavcodec/alsdec.c: In function

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 20:05 GMT+01:00 Umair Khan : > The attached patch fixes the address sanitizer issue. Breaks compilation here, how did you test? libavcodec/alsdec.c: In function ‘decode_var_block_data’: libavcodec/alsdec.c:938:7: error: expected ‘}’ before ‘else’ Carl Eugen

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, On Sat, Nov 4, 2017 at 3:11 AM, Thilo Borgmann wrote: > Am 03.11.17 um 21:13 schrieb Paul B Mahol: >> On 11/3/17, Thilo Borgmann wrote: >>> Am 02.11.17 um 21:32 schrieb Umair Khan: Hi, On Fri, Oct 20, 2017 at 1:44 AM, Ronald S.

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Am 03.11.17 um 21:13 schrieb Paul B Mahol: > On 11/3/17, Thilo Borgmann wrote: >> Am 02.11.17 um 21:32 schrieb Umair Khan: >>> Hi, >>> >>> On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje >>> wrote: Hi, On Thu, Oct 19, 2017 at 4:03

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

On 11/3/17, Thilo Borgmann wrote: > Am 02.11.17 um 21:32 schrieb Umair Khan: >> Hi, >> >> On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje >> wrote: >>> >>> Hi, >>> >>> On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: >>> I

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Am 02.11.17 um 21:32 schrieb Umair Khan: > Hi, > > On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje wrote: >> >> Hi, >> >> On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: >> >>> I tried decoding the file in both the cases and I don't see any >>>

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje wrote: > > Hi, > > On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: > > > I tried decoding the file in both the cases and I don't see any > > address related error in the console while decoding.

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: > I tried decoding the file in both the cases and I don't see any > address related error in the console while decoding. Following is the > output after I apply the patch :- > [..] > Is there something which I'm

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi Ronald, On Sun, Oct 15, 2017 at 12:21 AM, Ronald S. Bultje wrote: > Hi Umair, > > On Sat, Oct 14, 2017 at 1:43 PM, Umair Khan wrote: > >> On Sat, Oct 14, 2017 at 8:02 PM, Ronald S. Bultje >> wrote: >> > Hi Umair, >> > >> > On Sat,

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

On Fri, Sep 22, 2017 at 01:54:27PM +0530, Umair Khan wrote: > On Thu, Sep 21, 2017 at 6:30 PM, Paul B Mahol wrote: > > On 9/21/17, Umair Khan wrote: > >> Hi Ronald, > >> > >> On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje > >> wrote:

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

On Thu, Sep 21, 2017 at 6:30 PM, Paul B Mahol wrote: > On 9/21/17, Umair Khan wrote: >> Hi Ronald, >> >> On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje >> wrote: >>> Hi Umair, >>> >>> On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

On 9/21/17, Umair Khan wrote: > Hi Ronald, > > On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje > wrote: >> Hi Umair, >> >> On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan wrote: >> >>> On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi Ronald, On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje wrote: > Hi Umair, > > On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan wrote: > >> On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol wrote: >> > On 9/10/17, Umair Khan

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi Umair, On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan wrote: > On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol wrote: > > On 9/10/17, Umair Khan wrote: > >> On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann > >

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol wrote: > On 9/10/17, Umair Khan wrote: >> On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann >> wrote: >>> >>> Hi, >>> >>> > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

On 9/10/17, Umair Khan wrote: > On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann > wrote: >> >> Hi, >> >> > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 >> >> this is yet another iteration of >> >>

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann wrote: > > Hi, > > > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 > > this is yet another iteration of > > http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/213005.html I see. I was keepnig reference

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 this is yet another iteration of http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/213005.html -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Hi, This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 I suggest removing the check because opt_order can be larger than block_length for the last frames. I checked this in reference codec as well. opt_order is larger than block_length for last 2 frames. Hence, I don't think