Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 07:14:54AM -0400, Ronald S. Bultje wrote: Hi, On Wed, Mar 11, 2015 at 9:00 PM, Michael Niedermayer michae...@gmx.at wrote: Found-by: Clang -fsanitize=shift Reported-by: Thierry Foucu tfo...@google.com Signed-off-by: Michael Niedermayer michae...@gmx.at ---

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 09:57:44AM -0400, Ronald S. Bultje wrote: Hi, On Thu, Mar 12, 2015 at 9:37 AM, Michael Niedermayer michae...@gmx.at wrote: On Thu, Mar 12, 2015 at 07:14:54AM -0400, Ronald S. Bultje wrote: Hi, On Wed, Mar 11, 2015 at 9:00 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Ronald S. Bultje
Hi, On Thu, Mar 12, 2015 at 9:37 AM, Michael Niedermayer michae...@gmx.at wrote: On Thu, Mar 12, 2015 at 07:14:54AM -0400, Ronald S. Bultje wrote: Hi, On Wed, Mar 11, 2015 at 9:00 PM, Michael Niedermayer michae...@gmx.at wrote: Found-by: Clang -fsanitize=shift Reported-by:

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Christophe Gisquet
Hi, 2015-03-12 14:37 GMT+01:00 Michael Niedermayer michae...@gmx.at: const int mx = h-mv_cache[list][scan8[n]][0] + src_x_offset * 8; int my= h-mv_cache[list][scan8[n]][1] + src_y_offset * 8; const int luma_xy = (mx 3) + ((my 3) 2); -ptrdiff_t offset

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 03:39:51PM +0100, Christophe Gisquet wrote: Hi, 2015-03-12 14:37 GMT+01:00 Michael Niedermayer michae...@gmx.at: const int mx = h-mv_cache[list][scan8[n]][0] + src_x_offset * 8; int my= h-mv_cache[list][scan8[n]][1] + src_y_offset *

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Ronald S. Bultje
Hi, On Wed, Mar 11, 2015 at 9:00 PM, Michael Niedermayer michae...@gmx.at wrote: Found-by: Clang -fsanitize=shift Reported-by: Thierry Foucu tfo...@google.com Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/h264_mb.c | 14 +++--- 1 file changed, 7