Re: [FFmpeg-devel] [PATCH] avcodec: Remove libaacplus

2016-01-30 Thread Paul B Mahol
On 1/29/16, Timothy Gu wrote: > On Mon, Jan 25, 2016 at 01:16:56PM +0100, Michael Niedermayer wrote: >> On Sun, Jan 24, 2016 at 09:50:01AM -0800, Timothy Gu wrote: >> > It's inferior to fdk-aac and has an arguably more problematic >> > license. > >> a reference to the comparision finding its infer

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libaacplus

2016-01-29 Thread Timothy Gu
On Thu, Jan 28, 2016 at 07:47:40PM -0800, Timothy Gu wrote: > > If I see no more comments, I will push this patch in one or two days. Pushed with the libvo-aacenc removal patch. I will add a website news entry soon. Timothy ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libaacplus

2016-01-29 Thread Carl Eugen Hoyos
Timothy Gu gmail.com> writes: > > > It's inferior to fdk-aac and has an arguably more > > > problematic license. > > > > Needs a Changelog entry and a news entry together with > > libvo. > What do you mean by news entry? On the website? Yes, a news entry on the website mentioning the removal

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libaacplus

2016-01-28 Thread Timothy Gu
On Mon, Jan 25, 2016 at 10:23:57AM +, Carl Eugen Hoyos wrote: > Timothy Gu gmail.com> writes: > > > It's inferior to fdk-aac and has an arguably more problematic > > license. > > Needs a Changelog entry and a news entry together with > libvo. Changelog entry added locally. What do you mean

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libaacplus

2016-01-28 Thread Timothy Gu
On Mon, Jan 25, 2016 at 01:16:56PM +0100, Michael Niedermayer wrote: On Sun, Jan 24, 2016 at 09:50:01AM -0800, Timothy Gu wrote: > It's inferior to fdk-aac and has an arguably more problematic > license. a reference to the comparision finding its inferriority should be added to the commit mess

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libaacplus

2016-01-25 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 09:50:01AM -0800, Timothy Gu wrote: > It's inferior to fdk-aac and has an arguably more problematic > license. a reference to the comparision finding its inferriority should be added to the commit message the exact license should also be mentioned maybe [...] -- Michael

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libaacplus

2016-01-25 Thread Carl Eugen Hoyos
Timothy Gu gmail.com> writes: > It's inferior to fdk-aac and has an arguably more problematic > license. Needs a Changelog entry and a news entry together with libvo. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org