Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

On Tue, Jan 05, 2016 at 21:36:20 +0100, Moritz Barsnick wrote: > This is not the first of your filters where you describe a parameter as > a "percentage", but expect a float value [0, 1]. That is extremely > confusing, if not even wrong. To me, a percentage covers [0, 100]. You > need to find a

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

On Wed, Jan 6, 2016 at 5:36 AM, Moritz Barsnick wrote: > On Tue, Jan 05, 2016 at 21:36:20 +0100, Moritz Barsnick wrote: >> This is not the first of your filters where you describe a parameter as >> a "percentage", but expect a float value [0, 1]. That is extremely >> confusing,

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

On Tue, Jan 05, 2016 at 21:19:12 +0100, Paul B Mahol wrote: > +It accepts the following values: > +@table @samp > +@item replace > +logarithmic ^^^ This description is a copy/paste error. > +@item pheight > +Set histogram percentage of window height. [...] > +{ "pheight", "set histogram

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

On Wed, 30 Dec 2015 13:49:07 +0100, Paul B Mahol wrote: > diff --git a/doc/filters.texi b/doc/filters.texi [...] > +@item ascale > +Set amplitude scale. > + > +It accepts the following values: > +@table @samp > +@item log > +logarithmic > +@item lin > +linear > +@end table Default is