Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-23 Thread Michael Niedermayer
On Mon, Sep 19, 2016 at 07:01:49AM +0800, Steven Liu wrote: > 2016-09-19 0:24 GMT+08:00 Moritz Barsnick : > > > On Sun, Sep 18, 2016 at 23:40:34 +0800, Steven Liu wrote: > > > > > +if (byterange_mode) { > > > +version = 4; > > > +sequence = byterange_mode ? 0

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-23 Thread Steven Liu
ping 2016-09-19 7:01 GMT+08:00 Steven Liu : > > > 2016-09-19 0:24 GMT+08:00 Moritz Barsnick : > >> On Sun, Sep 18, 2016 at 23:40:34 +0800, Steven Liu wrote: >> >> > +if (byterange_mode) { >> > +version = 4; >> > +sequence =

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-18 Thread Steven Liu
2016-09-19 0:24 GMT+08:00 Moritz Barsnick : > On Sun, Sep 18, 2016 at 23:40:34 +0800, Steven Liu wrote: > > > +if (byterange_mode) { > > +version = 4; > > +sequence = byterange_mode ? 0 : sequence; > > What does the ternary if-then-else operation do here? Two

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-18 Thread Moritz Barsnick
On Sun, Sep 18, 2016 at 23:40:34 +0800, Steven Liu wrote: > +if (byterange_mode) { > +version = 4; > +sequence = byterange_mode ? 0 : sequence; What does the ternary if-then-else operation do here? Two lines above, byterange_mode was checked for !=0, how can it be anything

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-18 Thread Steven Liu
2016-09-18 7:28 GMT+08:00 Steven Liu : > > > 2016-09-18 1:07 GMT+08:00 Michael Niedermayer : > >> On Sat, Sep 17, 2016 at 01:09:02PM +0800, Steven Liu wrote: >> [...] >> > @@ -867,6 +886,16 @@ static int hls_write_header(AVFormatContext *s) >> >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-17 Thread Steven Liu
2016-09-18 1:07 GMT+08:00 Michael Niedermayer : > On Sat, Sep 17, 2016 at 01:09:02PM +0800, Steven Liu wrote: > [...] > > @@ -867,6 +886,16 @@ static int hls_write_header(AVFormatContext *s) > > for (i = 0; i < s->nb_streams; i++) { > > AVStream *inner_st; >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-17 Thread Michael Niedermayer
On Sat, Sep 17, 2016 at 01:09:02PM +0800, Steven Liu wrote: [...] > @@ -867,6 +886,16 @@ static int hls_write_header(AVFormatContext *s) > for (i = 0; i < s->nb_streams; i++) { > AVStream *inner_st; > AVStream *outer_st = s->streams[i]; > + > +if (hls->max_seg_size >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-16 Thread Steven Liu
2016-09-15 20:31 GMT+08:00 Steven Liu : > > > 2016-09-14 6:51 GMT+08:00 Steven Liu : > >> >> >> 2016-09-14 2:53 GMT+08:00 Moritz Barsnick : >> >>> On Tue, Sep 13, 2016 at 11:25:39 +0800, Steven Liu wrote: >>> > +int

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-15 Thread Steven Liu
2016-09-14 6:51 GMT+08:00 Steven Liu : > > > 2016-09-14 2:53 GMT+08:00 Moritz Barsnick : > >> On Tue, Sep 13, 2016 at 11:25:39 +0800, Steven Liu wrote: >> > +int byterange_mode = hls->flags & (HLS_SINGLE_FILE) || >> hls->max_seg_size > 0; >>

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-13 Thread Steven Liu
2016-09-14 2:53 GMT+08:00 Moritz Barsnick : > On Tue, Sep 13, 2016 at 11:25:39 +0800, Steven Liu wrote: > > +int byterange_mode = hls->flags & (HLS_SINGLE_FILE) || > hls->max_seg_size > 0; > ^ ^ > Why the bracket? > > >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-13 Thread Moritz Barsnick
On Tue, Sep 13, 2016 at 11:25:39 +0800, Steven Liu wrote: > +int byterange_mode = hls->flags & (HLS_SINGLE_FILE) || hls->max_seg_size > > 0; ^ ^ Why the bracket? > +av_log(oc, AV_LOG_ERROR, "Invalid segment filename

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-12 Thread Steven Liu
2016-09-13 8:20 GMT+08:00 Michael Niedermayer : > On Tue, Sep 13, 2016 at 06:49:41AM +0800, Steven Liu wrote: > > 2016-09-13 6:19 GMT+08:00 Michael Niedermayer : > > > > > On Mon, Sep 12, 2016 at 07:04:54PM +0800, Steven Liu wrote: > > > >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-12 Thread Michael Niedermayer
On Tue, Sep 13, 2016 at 06:49:41AM +0800, Steven Liu wrote: > 2016-09-13 6:19 GMT+08:00 Michael Niedermayer : > > > On Mon, Sep 12, 2016 at 07:04:54PM +0800, Steven Liu wrote: > > > 2016-09-12 18:52 GMT+08:00 Michael Niedermayer : > > > > > > > On

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-12 Thread Steven Liu
2016-09-13 6:19 GMT+08:00 Michael Niedermayer : > On Mon, Sep 12, 2016 at 07:04:54PM +0800, Steven Liu wrote: > > 2016-09-12 18:52 GMT+08:00 Michael Niedermayer : > > > > > On Mon, Sep 12, 2016 at 05:39:31PM +0800, Steven Liu wrote: > > > >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-12 Thread Michael Niedermayer
On Mon, Sep 12, 2016 at 07:04:54PM +0800, Steven Liu wrote: > 2016-09-12 18:52 GMT+08:00 Michael Niedermayer : > > > On Mon, Sep 12, 2016 at 05:39:31PM +0800, Steven Liu wrote: > > > 2016-09-12 17:35 GMT+08:00 Steven Liu : > > > > > > > > > > > > >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-12 Thread Steven Liu
2016-09-12 18:52 GMT+08:00 Michael Niedermayer : > On Mon, Sep 12, 2016 at 05:39:31PM +0800, Steven Liu wrote: > > 2016-09-12 17:35 GMT+08:00 Steven Liu : > > > > > > > > > > > 2016-09-12 17:28 GMT+08:00 Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-12 Thread Michael Niedermayer
On Mon, Sep 12, 2016 at 05:39:31PM +0800, Steven Liu wrote: > 2016-09-12 17:35 GMT+08:00 Steven Liu : > > > > > > > 2016-09-12 17:28 GMT+08:00 Michael Niedermayer : > > > >> On Mon, Sep 12, 2016 at 03:01:24PM +0800, Steven Liu wrote: > >> > refine

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-12 Thread Steven Liu
2016-09-12 17:35 GMT+08:00 Steven Liu : > > > 2016-09-12 17:28 GMT+08:00 Michael Niedermayer : > >> On Mon, Sep 12, 2016 at 03:01:24PM +0800, Steven Liu wrote: >> > refine EXT-X-BYTERANGE tag, >> > the spec link: >> >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-12 Thread Steven Liu
2016-09-12 17:28 GMT+08:00 Michael Niedermayer : > On Mon, Sep 12, 2016 at 03:01:24PM +0800, Steven Liu wrote: > > refine EXT-X-BYTERANGE tag, > > the spec link: > > https://tools.ietf.org/html/draft-pantos-http-live- > streaming-19#section-4.3.2.2 > > > > the apple doc: >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-12 Thread Michael Niedermayer
On Mon, Sep 12, 2016 at 03:01:24PM +0800, Steven Liu wrote: > refine EXT-X-BYTERANGE tag, > the spec link: > https://tools.ietf.org/html/draft-pantos-http-live-streaming-19#section-4.3.2.2 > > the apple doc: >