Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-19 Thread Andreas Cadhalpun
On 19.10.2016 22:45, Michael Niedermayer wrote: > On Wed, Oct 19, 2016 at 07:27:59PM +0200, Andreas Cadhalpun wrote: >> f1f2b8b10efdab27848eeb2e2bac646eda08a175 >> 0001-avformat-prevent-triggering-request_probe-assert-in-.patch >> From 7912c6f200a37130844221a73941a7971afa6455 Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-19 Thread Andreas Cadhalpun
On 19.10.2016 05:29, Michael Niedermayer wrote: > hmm, i guess the patch is then ok > alternatively you could use i think: > @@ -803,7 +803,7 @@ int ff_read_packet(AVFormatContext *s, AVPacket *pkt) > return ret; > for (i = 0; i < s->nb_streams; i++) { >

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 11:26:24PM +0200, Andreas Cadhalpun wrote: > On 18.10.2016 22:56, Michael Niedermayer wrote: > > On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: > >> Nothing guarantees to set request_probe to -1, so this assert can be > >> triggered, e.g. if

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Andreas Cadhalpun
On 18.10.2016 23:46, Hendrik Leppkes wrote: > On Tue, Oct 18, 2016 at 11:26 PM, Andreas Cadhalpun > wrote: >> On 18.10.2016 22:56, Michael Niedermayer wrote: >>> On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: Nothing guarantees to set

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Hendrik Leppkes
On Tue, Oct 18, 2016 at 11:26 PM, Andreas Cadhalpun wrote: > On 18.10.2016 22:56, Michael Niedermayer wrote: >> On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: >>> Nothing guarantees to set request_probe to -1, so this assert can be >>>

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Andreas Cadhalpun
On 18.10.2016 22:56, Michael Niedermayer wrote: > On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: >> Nothing guarantees to set request_probe to -1, so this assert can be >> triggered, e.g. if st->probe_packets is 0. > > probe_codec() called with NULL should cause >

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: > Nothing guarantees to set request_probe to -1, so this assert can be > triggered, e.g. if st->probe_packets is 0. probe_codec() called with NULL should cause st->probe_packets = 0 st->request_probe = -1; [...] -- Michael