Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: Enable MB rate control

2017-05-14 Thread Mark Thompson
On 12/05/17 05:00, Jun Zhao wrote: > On 2017/5/11 19:39, Mark Thompson wrote: >> On 11/05/17 01:29, Jun Zhao wrote: >>> From b32e4c9c1de47b3bf76327b0ecd11ccf9e3c693f Mon Sep 17 00:00:00 2001 >>> From: Jun Zhao >>> Date: Tue, 9 May 2017 08:19:16 +0800 >>> Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: Enable MB rate control

2017-05-11 Thread Jun Zhao
On 2017/5/11 19:39, Mark Thompson wrote: > On 11/05/17 01:29, Jun Zhao wrote: >> Enable the MB level rate control, verified in i965 driver master branch with >> Skylake. > > I think it makes sense to expose this, but can you explain a bit more what > this actually does? All I can see in the

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: Enable MB rate control

2017-05-11 Thread Mark Thompson
On 11/05/17 01:29, Jun Zhao wrote: > Enable the MB level rate control, verified in i965 driver master branch with > Skylake. I think it makes sense to expose this, but can you explain a bit more what this actually does? All I can see in the i965 driver is that it allocates an extra buffer